- 🇺🇸United States AaronBauman Philadelphia
#107 worked for me.
Please commit and push a new release.
This module broke my site. - 🇳🇱Netherlands eelkeblok Netherlands 🇳🇱
I updated the issue summary in hopes of giving this a boost; the module is currently incompatible with supported versions of Drupal. There are currently two viable patches, both of which take different approaches. People have reported both of them working (I myself have been running a site with #25 for several months). Can the maintainers please make a choice, with, I guess, some bias towards #25 as it has a longer history.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
For everyone who is commenting here that the patch works, I think its clear this module is actively supported anymore, and perhaps you might like to step up to co-maintain → .
- 🇭🇺Hungary lonalore Budapest, Hungary
Patch #107 works fine with Drupal 9.5.7.
- 🇮🇳India prempatel2447 Varanasi
Hi Everyone,
We will include all the changes in new release with Drupal 10 compatibility.
- 🇺🇸United States seantwalsh Eatontown, NJ
@prempatel2447 Do you have a date for releasing the D10 compatible version?
- Status changed to Needs review
about 1 year ago 10:58am 25 July 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks everyone. Moved to PR and refactored after D10 branch commit 📌 Automated Drupal 10 compatibility fixes Fixed .
Seems like middle ware is a bit of a overkill.
Please review. - @vladimiraus opened merge request.
- 🇺🇸United States dcam
@VladimirAus it seems like your commit didn't get uploaded to the MR.
- 🇺🇸United States generalredneck
Everyone,
So I was upgrading to D10, and we had been using #107.Obviously when I tried to apply it to the 8.x-2.x branch locally via composer, the patch failed. So I came here to reroll it.
That said, I got to looking at the latest commit, and I've found that the Reason VladimirAus's MR shows up as empty is because #25 has been merged and updated for D10. If you look in 📌 Automated Drupal 10 compatibility fixes Fixed , you will see where VladimirAus is asking everyone to review that commit and validate it function's correctly so we can have a new version.
So in theory, provided my tests work here in a little bit, this could be marked as "Fixed" provided we want to release without tests of the redirect functionality.
- 🇺🇸United States generalredneck
The commit appears to work for D9.5.10. It redirects as it's supposed to and even respects when a different ?destination=/some/path is passed to the form. I'd call this good minus specific tests provided the maintainer wants those to be a part of this work. Given that, the fix for this has already been commited to 8.x-2.x, so I'm inclined to vote we don't make this linger and create a new task for creating the test.
- 🇳🇱Netherlands jaapjan
Agree with comment #136. Fastest way forward seems to be to mark story as fixed and tag new release on current dev branch. Considering Drupal 9 is EOL in a few weeks it would be extremely helpful if a maintainer could tag a new release.
For now one could use version constraint
dev-2.x#2fa71b6196c64b93e8377f02e2e6d827bbe67ec8
. - 🇺🇸United States dzinkevich
Verifying that this works. We've been using this patch in production since it was released a year ago.
- 🇺🇸United States be-a-helper
@VladimirAus Tagging you in regarding the request for a prod release. How can the community support you in this?
- 🇺🇸United States adrianm6254
Is there a scheduled date for the D10 release yet?
- 🇦🇺Australia 2pha
the dev (8.x-2.x) version seems to have worked for me on a D8 to D9 upgrade.
Not sure why there is a specific 8.x-2.x-dev branch in the repo, but doing a composer require drupal/redirect_after_login:2.x-dev`does infact install (8.x-2.x) - 🇺🇸United States jackfoust
Am I correct in assuming that 2pha's comment above requiring the dev branch fixes both the "header already sent" issue and resolves the D10 compatibility issues?
- 🇦🇺Australia 2pha
@jackfoust I only moved the site to the latest D9 at this stage, I'll check back in here when I move the site to D10 in the near future.
- Status changed to RTBC
11 months ago 11:42am 29 October 2023 - 🇨🇭Switzerland pvbergen
We had the patches from this issue in use for over 2 years.
I can verify that MR#5 applies correctly and resolves the issue on D9 and D10. - 🇭🇺Hungary djg_tram
@pvbergen -- This module is obviously abandoned, I'd say the best solution is to quit using it and if you need the functionality, use your own module or start another one. I never did, as I described two years ago, I came here to chime in because my own code had the same problem.
Two years ago, one of the core members of the Drupal team clearly described that the solution this module had used previously was plainly wrong and provided the proper solution. After that, two days of testing should have been enough to change it for once and for all. This never happened, so, after all that time, there are inevitable conclusions to draw...
Someone take over maintainership. https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
- 🇭🇺Hungary nevergone Nyíregyháza, Hungary, Europe
@Prem Patel is active developer.
-
VladimirAus →
committed 7371e1c3 on 8.x-2.x
Issue #3214949 by larowlan, Andrew Answer, djg_tram: Headers have...
-
VladimirAus →
committed 7371e1c3 on 8.x-2.x
- 🇦🇺Australia VladimirAus Brisbane, Australia
Great work everyone!
Merged into 2.x and 3.x. Working on the releases. -
VladimirAus →
committed 7371e1c3 on 3.0.x
Issue #3214949 by larowlan, Andrew Answer, djg_tram: Headers have...
-
VladimirAus →
committed 7371e1c3 on 3.0.x
- Status changed to Fixed
11 months ago 9:36am 2 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.