πŸ‡ΊπŸ‡ΈUnited States @dzinkevich

Account created on 23 June 2015, over 9 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

Looks like a patch was very very easy :)

I'm not sure if this is the direction maintainers would like to go, but this adds a twig function that finds the field of a given revision.

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

Coming here with the same issue. One use case is that I inherited a client who has a hero image which is configured at the node level but displayed outside of the node's content region.

When a user submits this node for approval, we don't want to display the current revision, we want to show the revision of the page that we get from the route.

Going to look into this and see how difficult a patch would be.

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

dzinkevich β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

Verifying that this works. We've been using this patch in production since it was released a year ago.

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

Actually it appears that coordination will be impossible - https://symfony.com/blog/the-end-of-swiftmailer. I suppose the solution is to use symfony mailer instead, which supports email-validator 4.0.1 https://github.com/symfony/mailer/blob/6.3/composer.json

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

upgrade_status reported a few more issues - here is a patch that includes fixes for three of them:

$ drush upgrade_status:analyze xmlsitemap
[notice] Processing /app/drupal/docroot/modules/contrib/xmlsitemap.

================================================================================
XML Sitemap, 8.x-1.5
Scanned on Thu, 09/28/2023 - 01:02

FILE:
modules/contrib/xmlsitemap/tests/src/Functional/XmlSitemapFunctionalTest.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Fix now 36 Call to deprecated method drupalGetHeader() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.2.0 and
is removed from drupal:10.0.0. Use
$this->getSession()->getResponseHeader() instead.
--------------------------------------------------------------------------------
Fix now 37 Call to deprecated method drupalGetHeader() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.2.0 and
is removed from drupal:10.0.0. Use
$this->getSession()->getResponseHeader() instead.
--------------------------------------------------------------------------------

FILE:
modules/contrib/xmlsitemap/tests/src/Functional/XmlSitemapTaxonomyFunctionalTest
.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Fix now 67 Call to deprecated function
taxonomy_term_load_multiple_by_name(). Deprecated in
drupal:9.3.0 and is removed from drupal:10.0.0. Use
Drupal::entityTypeManager()->getStorage('taxonomy_term')->lo
adByProperties(['name' => $name, 'vid' => $vid]) instead, to
get a list of taxonomy term entities having the same name
and keyed by their term ID.
--------------------------------------------------------------------------------

FILE: modules/contrib/xmlsitemap/xmlsitemap.module

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Fix now 2325 Call to deprecated method implementsHook() of class
Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in
drupal:9.4.0 and is removed from drupal:10.0.0. Use the
hasImplementations() methods instead with the $modules
argument.
--------------------------------------------------------------------------------
Check manually 2337 A file could not be loaded from
Drupal\Core\Extension\ModuleHandlerInterface::loadInclude
--------------------------------------------------------------------------------

πŸ‡ΊπŸ‡ΈUnited States dzinkevich

Here is a patch that shows the full filename on hover:

Production build 0.71.5 2024