🇨🇭Switzerland @pvbergen

I was Session Monitor for 'Human Centred Design: An introduction for Drupal people (and how to make it work for you)'.

I was Session Monitor for 'Unleash all Drupal features: how ambitious site builders take it to the next level with ECA and BPMN'.

I was Session Monitor for 'Engaging a user in a multibrand environment.' / 'Accelerating Transformation in Web Accessibility on Enterprise Level'.

Comment for credits ;)

Comment for credit ;)

Comment for credit ;)

Comment for credit ;)

vrancje → credited pvbergen → .

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

I've updated the changes from #5 for 3.x and created a fork/MR.

pvbergen → made their first commit to this issue’s fork.

pvbergen → made their first commit to this issue’s fork.

pvbergen → created an issue.

pvbergen → changed the visibility of the branch 3352372-resolve-issues-in to hidden.

pvbergen → created an issue.

Thanks for raising this issue.
You seem to have a different version of ui_patterns required in your lock file. You need to downgrade to ui_patterns:~1.5 to use pagedesigner.

We fixed the version for pagedesigner as we encountered issues with 1.6 and higher.
We would need tests to make sure that the change of the version of ui_patterns no longer breaks pagedesigner to lift the constraint here.

As ui_patterns 2.x is in the works using SDC in core, we plan to update at the earliest once we have a stable 2.0 release of ui_patterns.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

Updated title, IS

I created a similar issue in 📌 Webform from address not set as sender address when using symfony_mailer Needs review .
I also add a MailAdjuster, which automatically takes the primary from address and sets it as a sender.

I would propose to combine the plugins to provide more configuration:
- Take the primary from address or
- Manually set a sender email.

Or should we add separate adjusters?

Nevermind... I got mislead by a failing query to check the size of my cache tables and then misunderstood the implementation. Closing as duplicate again.

I stumbled upon this issue almost 10 years later and it is not resolved by #2526150.
DatabaseBackend::garbageCollection still excludes entries marked as permanent from being deleted: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...

I'm reopening this to determine whether this is expected behaviour or something we have to address.
For me, this was a surprise as https://www.drupal.org/node/2891281 → doesn't mention permanent items being kept.

pvbergen → created an issue.

@AdamPS:
Thanks for the feedback. I didn't see #3388651 before but I also think it addresses another, more global request.

Using this adjuster would allow finegrained control which mails the sender should be overwritten for.
This would leave the default implementation with their valid concerns unaffected while still allowing site builders to specifically select exceptions.

We often have projects where we use different sender addresses (using the same domain) on webforms becaus of (strong) client request and this would allow us to fulfill this request without custom code. I also argue that webform mails are not in the same class as general site notifications and can fulfill very different purposes.

Sidenote: Fixed the typo in my class.

pvbergen → created an issue.

I've stumbled upon this issue, experiencing multiple loads on after scrolling down using infinite scrolls. I investigated and found the same reasoning as rgpublic. Each ajax load adds another handler to the submit button.

I can confirm that removing the line "once.remove('exposed-form', view.$exposed_form);" resolves this issue (Commit: https://git.drupalcode.org/issue/views_infinite_scroll-3035601/-/commit/...)

For test coverage and next steps:
- I will do user testing on our project, maybe I can try to find some test to cover that automatically.
- It might also be an option to make this configurable. I can imagine both use cases, either reloading the same number of pages on filter change or just loading the first page. In this case we could make reloading all pages the default behavior, which makes this change transparent for existing websites.

@jrockowitz
I'm a bit unsure with symfony_mailer, so I can't tell, what approach is best.

Thinking about it, I realize that my adjuster should go into drupal/symfony_mailer.
It just takes the first from address and sets it as a sender, which might be a broader use case.
The WebformEmailBuilder from #3260134 should go into drupal/webform, as it is opinionated towards webform.

I adjusted this issue to be in Symfony Mailer.

pvbergen → created an issue.

Thanks for raising this issue. This is already being resolved in 4.x, which also will include some interface changes.
We won't update 3.x with these changes anymore.

Closing as outdated.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

pvbergen → created an issue.

codebymikey → credited pvbergen → .

pvbergen → created an issue.