Use dependency injection for plugin dependencies

Created on 22 December 2023, 6 months ago
Updated 6 February 2024, 5 months ago

Problem/Motivation

Many pagedesigner plugins contain direct calls to \Drupal:: to retrieve service. We should provide a retrieval object to prevent direct calls.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Closed: outdated

Version

3.0

Component

Code

Created by

🇨🇭Switzerland pvbergen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @pvbergen
  • Assigned to ishanghosh27
  • 🇮🇳India ishanghosh27

    @pvbergen
    Fixed all phpcs issues except this one -
    FILE: /pagedesigner/tests/src/Kernel/AbstractPagedesignerTest.php
    -------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------------------
    21 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
    -------------------------------------------------------------------------------------------------------------------------------------------------
    Please review and let me know in case of any concerns.

  • Status changed to Closed: outdated 5 months ago
  • 🇨🇭Switzerland pvbergen

    Thanks for raising this issue. This is already being resolved in 4.x, which also will include some interface changes.
    We won't update 3.x with these changes anymore.

    Closing as outdated.

Production build 0.69.0 2024