Webform from address not set as sender address when using symfony_mailer

Should this be part of #3260134: Add EmailBuilder for Webform → ?

@jrockowitz
I'm a bit unsure with symfony_mailer, so I can't tell, what approach is best.

Thinking about it, I realize that my adjuster should go into drupal/symfony_mailer.
It just takes the first from address and sets it as a sender, which might be a broader use case.
The WebformEmailBuilder from #3260134 should go into drupal/webform, as it is opinionated towards webform.

I adjusted this issue to be in Symfony Mailer.

pvbergen → closed merge request !397

AFAICS Core MailManager sets Sender to site mail. I can't find any reference to Sender in swiftmailer.

This issue similar to ✨ Allow to customize Sender Active , especially see #2 for explanation of why in general it's not a good idea to set sender based on from.

@AdamPS:
Thanks for the feedback. I didn't see #3388651 before but I also think it addresses another, more global request.

Using this adjuster would allow finegrained control which mails the sender should be overwritten for.
This would leave the default implementation with their valid concerns unaffected while still allowing site builders to specifically select exceptions.

We often have projects where we use different sender addresses (using the same domain) on webforms becaus of (strong) client request and this would allow us to fulfill this request without custom code. I also argue that webform mails are not in the same class as general site notifications and can fulfill very different purposes.

Sidenote: Fixed the typo in my class.

Thanks for the update - I understand your point however it's not the same as the original IS😃.

As you say this seems like a bit of a specialised situation. I am concerned that many simple site-owners could be confused by this adjuster and perhaps use it incorrectly causing their emails to bounce. Perhaps it belongs back in Webform module after all??

Updated title, IS

✨ Allow to customize Sender Active seems like a better UX to me. What do you think?

Or we could add a setting on from adjuster "also use as sender" (causes error if there is more than one from)?

I propose we should have a description that explains:
- by default the sender address comes from "Basic site settings" and normally you wouldn't change it
- ensure this server is authorised to send from the specified address to help prevent emails being flagged as spam

In the end we did ✨ Allow to customize Sender Active instead however thanks for the patches