- Issue created by @gaspounet
- Status changed to Needs review
about 1 year ago 5:19am 22 August 2023 - last update
about 1 year ago 34 pass - ๐ฎ๐ณIndia keshavv India
There is no constant with name
SEARCH_API_SOLR_SCHEMA_VERSION
in Search Api Solr module.
useSEARCH_API_SOLR_MIN_SCHEMA_VERSION
instead. - ๐ซ๐ทFrance gaspounet
Thank you very much @keshavv for this patch, I can confirm that the error messages have disappeared now and that I can use again the autocomplete feature!
- Status changed to RTBC
about 1 year ago 8:46am 5 September 2023 - ๐ซ๐ทFrance manu manu Aix-en-Provence
Can confirm the patch in #3 fixes the issue, thank you @keshavvv.
Switching to RTBC
- First commit to issue fork.
- ๐จ๐ณChina hongqing
Thanks. It works with Drupal 10.1.4 and Search Api autocomplete 8.x-1.7
- ๐ฌ๐งUnited Kingdom 2dareis2do
Same here. Many thanks for the fix. This looks like the commit that has broken this:
https://git.drupalcode.org/project/search_api_solr/-/commit/cdf4b1fdc973...
- Status changed to Needs work
about 1 year ago 5:50pm 26 September 2023 - ๐ท๐ดRomania claudiu.cristea Arad ๐ท๐ด
Well, it works but what if search_api_solr has an older version where the old constant has been used? I think the existence of each constant should be checked.
- ๐ท๐ดRomania claudiu.cristea Arad ๐ท๐ด
Also, the old constant has been deprecated prior to be deleted. See https://git.drupalcode.org/project/search_api_solr/-/commit/cdf4b1fdc973... :
/** * The current Solr schema version. * * @deprecated use getPreferredSchemaVersion() */ public const SEARCH_API_SOLR_SCHEMA_VERSION = '4.2.13';
In the deprecation notice they recommend to use
SearchApiSolrBackend::getPreferredSchemaVersion
instead. - First commit to issue fork.
- last update
about 1 year ago 34 pass - @bvoynick opened merge request.
- last update
about 1 year ago 34 pass - ๐บ๐ธUnited States bvoynick
Updated MR to use the method, and to fall back to the old < 4.3.0 constant if the method does not exist.
- Status changed to Needs review
about 1 year ago 7:03pm 26 September 2023 - Status changed to RTBC
about 1 year ago 8:18pm 26 September 2023 - ๐บ๐ธUnited States laura.gates
#13's patch works for me and clears the white screen of death on /admin/reports/status
- ๐ช๐จEcuador jwilson3
RTBC++ We're currently using this one to charge forward with D10 upgrades on a client project.
- ๐ฌ๐งUnited Kingdom 2dareis2do
Thanks @bvoynick. Looks good to me but is quite difficult to read.
- ๐ฉ๐ชGermany Rar9
+1 3382226-3.patch working well status update displays again
- ๐จ๐ฆCanada joseph.olstad
+1 , hitting this and going to use the patch #13
our /admin/config route is blown otherwise - Status changed to Needs review
about 1 year ago 10:09am 1 October 2023 - last update
about 1 year ago 34 pass - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks a lot for reporting this problem and providing several great patches.
However, checking #3257941: Mention search_api_solr_autocomplete โ confirms that the only reason we compare the schema version is to detect whether the
search_api_solr_autocomplete
module is even available. If thegetPreferredSchemaVersion()
method exists, then that just means that the Solr module version is even newer and we donโt even need to check the version number.I think the attached patch is a lot easier to read and should work just as well, no matter which Solr module version youโre using.
Please give it a try (and/or review) and I can commit it. - Status changed to RTBC
about 1 year ago 12:57pm 1 October 2023 - ๐ญ๐บHungary lonalore Budapest, Hungary
#22 patch works for me. Drupal 9.5.11 with Search API Solr 4.3.0.
- ๐ฌ๐งUnited Kingdom 2dareis2do
Thanks drunken monkey.
Latest patch installed and working for me on dev/production environments.
Had to delete and recreate the collection locally for some reason but that was probably caused by an earlier update.
Much easier to read.
- ๐จ๐ฆCanada SKAUGHT
also to help confirm:
tested patch #22 on local setup of client works! -
drunken monkey โ
committed 238e6630 on 8.x-1.x authored by
bvoynick โ
Issue #3382226 by bvoynick, drunken monkey, keshavv, claudiu.cristea:...
-
drunken monkey โ
committed 238e6630 on 8.x-1.x authored by
bvoynick โ
- Status changed to Fixed
about 1 year ago 10:33am 7 October 2023 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Great to hear, thanks for all your comments.
Merged this. Thanks again, everyone!
Iโll try to create a new release soon. - ๐ช๐ธSpain DaAira
tested patch #22 and worked for me.
Thanks, drunken monkey - ๐ฎ๐ณIndia JaydipJD surat
Patch is merged and released as part of '8.x-1.8'.
Automatically closed - issue fixed for 2 weeks with no activity.