surat
Account created on 26 July 2019, almost 5 years ago
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have raised merge request. Lets wait its to be merge and new release.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

JaydipJD โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have re-rolled the patch for 2.0.0-alpha3

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

We are waiting this changes to be release since long. We must have to upgrade the latest release of this module on our site. Hence created patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I had a look at the conversation above. It is better to provide widget setting to control the behavior.
I have rerolled the patch #15

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have removed ajax response which return on closing the model.
We are getting success message in a new popup once we save the entity and here contributor require extra effort to close the popup having success message. We are already getting error messages in a same popup hence as per my opinion to show extra popup for success message seems bad UX.

Any different suggestions or solutions are most welcome.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Modified patch to display error messages only on the entity browser popup.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Didn't get any error when i disabled aggregation for js and css.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I am facing the same issue today. I just took fresh D10.1.2 and did local setup. I am getting the same error when i hit drush cr. permission for files directory got changed automatically.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Patch #74 is working fine. Hiding mine.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

[error] SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'source_uuid' cannot be null: INSERT INTO "coh_usage" ("source_uuid", "source_type", "requires_uuid", "requires_type") VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3); Array
> (
> [:db_insert_placeholder_0] =>
> [:db_insert_placeholder_1] => entity_view_display
> [:db_insert_placeholder_2] => b23bb549-4b29-488f-9bf8-16a183cdac64
> [:db_insert_placeholder_3] => node_type
> )
>
> [error] Update failed: system_post_update_timestamp_formatter
> [warning] Invalid placeholder (severity_level) with string: "%type: @message in %function (line %line of %file)." FormattableMarkup.php:245
> [warning] Invalid placeholder (exception) with string: "%type: @message in %function (line %line of %file)." FormattableMarkup.php:245
[error] Update aborted by: system_post_update_timestamp_formatter

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Created patch to use till changes got merge and new version release.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Created patch from Merge request 7(https://git.drupalcode.org/project/footnotes/-/merge_requests/7) to use till latest changes got merge and new version release.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Removed Patch created. No change. Uploaded same patch by mistake.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Re-rolled patch against 3.1.0

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have re-roll the patch for D10.1.1 from MR 3681

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Modified patch to add Drupal 10 support.
core_version_requirement: ^8.8 || ^9 modified to core_version_requirement: ^9.5 || ^10

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

fixed the mistake I made in previous patch.

I have re-roll the patch for 9.5.x from MR 3681 (https://git.drupalcode.org/project/drupal/-/merge_requests/3681)

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Full Drupal 10 patch has been created so that others can use this patch till latest release.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have added Dependency injection and other phpcs warning fixes. Please review it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

JaydipJD โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I will review and merge it later.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have applied PHPCS fixes as well.
Tested OK.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

JaydipJD โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Thanks @cottser for the contribution. I will review and release this version once work done.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat
๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Added Missing parenthesis.
Created patch against 1.x branch

use this patch with 1.x branch like mentioned here: composer require 'drupal/field_zip_file:1.x-dev'

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

PHPCS warning fixes has been added.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat
๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat
๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

I have added fixes code at https://git.drupalcode.org/project/field_zip_file/-/merge_requests/5 with Drupal 10 Readiness branch. I am marking this issue as a fixed and will changes the status once the code will merge with the 1.x branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat
๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat
๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

JaydipJD โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

Patch against 1.x branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia JaydipJD surat

On php 8.1, Still causing the same issue. Fixes have been added.
Created patch against 1.0.0-beta2 version.

Production build 0.69.0 2024