All footnotes available as block for Layout Builder / Paragraph / ...

Issue with the footnotes block looks to be due to the cache keys not being set correctly. I've added cache keys, tags and context to the render array built by the FootnotesGroupBlock which fixes the cache issue for me.

This is reroll of the patch file from comment 71 against the latest release 3.1.

Created patch from Merge request 7(https://git.drupalcode.org/project/footnotes/-/merge_requests/7) to use till latest changes got merge and new version release.

Patch #74 is working fine. Hiding mine.

I've been thoroughly testing this change out with and without caching, dynamic page caching, and big pipe enabled or not and confirmed this is working.

Hi,

I'm still experiencing those cache issues with latest patches.

1. Clear caches
2. First load -> Footnotes are there
3. Second load -> Footnotes are gone forever (until next cache clear or invalidation)

After some debugging I have seen that the plugin is not collecting the footnotes after the cache is clear. I have seen in the annotation of the FootnotesFilter.php that there is a "* cache = FALSE," but it seems that the plugin is cached anyway.

I have added a $result->setCacheMaxAge(0); into the process() of the FootnotesFilter.php so it's processed always and not just when we clear caches.

Attached the patch from the MR7 + the cache max-age=0

I was running into an issue with the patch from #79 📌 All footnotes available as block for Layout Builder / Paragraph / ... Needs review where the footnotes-multi links would display even on footnotes with one reference. I have updated the patch to only show the footnote-multi links when there are multiple references.

Going to merge this into 4x and created a follow-up here 📌 Follow-up to all footnotes available as a block to apply to modal plugin Active to apply to modal plugin to apply it to the new modal version before the old one gets retired. Patches still needed while on 3x until 4x (and its upgrade path are more stable).

I think the $result->setCacheMaxAge(0); is unnecessary and will break page cache. Setting the entity context_definitions in the block configuration seemed like it was required for caching to work properly:

Thanks for the feedback! I believe we have that looking at FootnotesGroupBlock; it attempts to load the current entity as a cache context and merges that meta data into the build. Though since it is not required, perhaps at the very least we should document that that should be selected. I am not sure it makes sense to require it as I imagine there are cases where someone could use Footnotes in a non-node/non-entity context. I made a note of that here: https://www.drupal.org/project/footnotes/issues/3413186 📌 Improve documentation of footnotes features and upgrade path Active

I have left out the merge of setCacheMaxAge(0), and it can be picked up in a follow-up issue if needed, but I agree that it makes sense to cache as much as we can by default as a starting point.

Automatically closed - issue fixed for 2 weeks with no activity.