πŸ‡ΊπŸ‡ΈUnited States @matthand

Riverdale Park, Maryland
Account created on 8 August 2007, almost 17 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Hi @cmlara,

The assumption that the scheme will always be public is based on the routes defined in the Image module. See https://api.drupal.org/api/drupal/core%21modules%21image%21src%21Routing... where the directory path is set by using the method `->getViaScheme('public')`.

It looks to me like this MR fixes the bug introduced by the update to Drupal 10.3. If we need to make other improvements isn't that better to do in the issue you linked?

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

I still see this as an issue in Drupal 10. Even clearing the browser cache data doesn't easily solve the problem for the visitor. If a visitor already visited the website previously, the cached version of the logo and favicon is displayed even if there is a newer version of the files. Adding a cache busting query string looks like a good solution to me.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Is there a way to re-enable the UUID field that is disabled on node resources by JSON:API without this new enableField method? I don't think so. Real world scenario of trying to match a legacy Drupal 8 JSON:API endpoint to prevent consumer apps requiring a rebuild.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland
πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Merged!

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland
πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

This is reroll of the patch file from comment 71 against the latest release 3.1.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Hi jonathan1055, We rely on the Scheduler module for our Drupal 9 websites. We want to clear our path to Drupal 10 upgrade. I can see that Scheduler only has one more bug fix pending and some docs changes before a stable release. What help do you need? We will start by testing out the current patch for https://www.drupal.org/project/scheduler/issues/3336108 πŸ› Don't run hook_modules_installed during config install Fixed .

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

We are interested in seeing this fix released for Scheduler module. Is it possible to make a new release candidate? What do you need help with?

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Starting progress on the Twig filter.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

I merged a drupalci.yml file into 2.x branch. This should give us a good starting point for CI integration. I could use a review to ensure I'm using reasonable defaults for my project.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland
πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Since there's little usage of the Drupal 7 release, there's no need to add testing support for that version. We added Kernel tests to the 2.x branch and will release soon when the stable version 2.0 is issued.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Tests are now available for the 2.x branch.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland
πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

In progress adding tests to 2.x-dev.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Changing to new default branch of 2.x-dev.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Hi @pub497,

Thank you for submitting the bug report. I'm not able to reproduce your bug. Can you please check that you ran 'drush cr' before the 'drush fr' commands? We checked the latest release and there's an update hook that should run and flush the container cache. This would fix the error your seeing.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Features version 8.x-3.13 is released β†’ that drops support for D8 and adds support for D10. Great work community! Thank you for your contributions.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Features version 8.x-3.13 was just released β†’ and includes this new enhancement. Thank you for your contribution!

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Features version 8.x-3.13 was just released β†’ and includes this bugfix. Thank you for the contribution, Dave!

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Features Version 8.x-3.13 was just released β†’ and includes this fix. Thank you for your contribution.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Fix is now merged into 3.x-dev branch. Thank you, Dave!

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

There was a manual check for a "yes" argument that was not needed and causing the log of the PHP Warning message. This is now resolved using the MR branch in local testing with Drush.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Thanks for reviewing and testing community. This change looks ready to merge into 3.x-dev branch. Marking as fixed.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

matthand β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

This fix is merged into 3.x-dev. We are going to commit a few more issues and then cut a new stable release for the 3.x branch.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Reviewed the code in GitLab. This merge request was already running on Drupal 10 websites. The D10 test is passing and D9 with 3 versions of PHP. Let's merge this in and cut a new stable release.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

@nedjo, I work with @dave-reid and would be happy to volunteer for co-maintainer.

πŸ‡ΊπŸ‡ΈUnited States matthand Riverdale Park, Maryland

Confirming the patch in comment 9 applies clean from composer.json and resolves this issue. It also fixes the related issue
"Local Tasks menu is shown even when the tray is empty" πŸ› Local Tasks menu is shown even when the tray is empty Closed: outdated . Moving to status "Reviewed & tested by the community".

Production build 0.69.0 2024