- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
Verified the test coverage running locally without the fix. I got
Error : Call to undefined method Drupal\jsonapi\ResourceType\ResourceTypeBuildEvent::enableField()
Which is good!
All threads are resolved on the MR
All tests are green
Change record is added and make sense (to me at least)
New functions are typehintedThis looks good to me.
- Status changed to Needs review
about 1 year ago 12:31am 19 March 2023 - π¬π§United Kingdom alexpott πͺπΊπ
There are several other options here. You could alter the service that subscribes the event or you could implement an event subscriber with a higher priority and stop propagation. I'm not sure that adding
enableField()
to fight it out withdisableField()
is going to improve the situation. I can imagine people adding an event to disable a field, that was disabled and then enabled. Feels odd. - Status changed to Needs work
about 1 year ago 3:20am 1 April 2023 - πΊπΈUnited States smustgrave
Alright issue should be reworked based on #22 or explained why this is the better approach.
Decision should be documented in issue summary please
Thanks.
- πΊπΈUnited States matthand Riverdale Park, Maryland
Is there a way to re-enable the UUID field that is disabled on node resources by JSON:API without this new enableField method? I don't think so. Real world scenario of trying to match a legacy Drupal 8 JSON:API endpoint to prevent consumer apps requiring a rebuild.