- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
I looked at the entire MR again, since it came up in one of Wim's XB weeks: https://wimleers.com/xb-week-24
I think the merge request looks great, and I don't have any big open questions, it needs a rebase and Wim needs to close some of the open questions (that's still only possible to do for the mr author).We also need to find an answer to the question highlighted in #282.
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
Since this was added to the IS, there was a complete rewrite of the patch, is it still valid? Do we have to postpone this on that?
Needs further investigation: #2905594: Missing entity validation constraint: don't allow new entities when there is an existing one with the same ID by @dawehner in #181. This might be a bit of missing test coverage?