- ๐ฉ๐ฐDenmark arnested
I'm pretty sure this is fixed / handled by the change in #2833129 โ .
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Thanks @plopesc! That makes sense. Thanks for the updates.
I've written a draft change record.
Also, updating the description to remove one more reference to footer_top as well as updating the screenshot to reflect the actual implementation.
As we only bumped back to needs work on docs related issues, marking this all the way to RTBC!
- ๐ช๐ธSpain plopesc Valladolid
Thank you for you review @m4olivei.
Footer is a more complex region than content and I would rather to discuss it in more detail in a follow-up issue.
Merging this one would unblock other integrations like Dashboard, Environment Indicator, Workspaces or Umami.
If you are OK with that, i think the only remaining step here would be to write the corresponding Change Record.
- ๐จ๐ฆCanada m4olivei Grimsby, ON
Looking good to me!
The MR doesn't address
footer_top
? I'm wondering if there was a specific reason why not that I'm missing. We either need to add that in as well, or update the issue description to reflect only content_top being covered here. Marking as Needs Work for this reason, but not wanting to discourage integrations from leaving thoughts as well, so please do feel free to leave review comments.