Contrib.social

Make specifing the configurable language types for LanguageNegotiatorInterface::updateConfiguration() optional

Open on Drupal.org →
Created on 26 November 2015, almost 9 years ago
Updated 30 January 2023, almost 2 years ago

Problem/Motivation

From #2618040-45: Configuration of configurable language types reset after module install → :

why do we do this here instead of a change in updateConfiguration()

I think we should look at that in a follow-up, my original patch was hoping that would work already (clearly it doesn't), but it'd also be a behaviour change so something we should change in 8.1.x.

Proposed resolution

Make the parameter optional and default to the current configuration, i.e. \Drupal::config('language.types')->get('configurable');.

Remaining tasks

Do it

User interface changes

None

API changes

Only additive

Data model changes

None

📌 Task
Status

Needs work

Version

10.1 ✨

Component
Language system  →

Last updated about 7 hours ago

  • Maintained by
  • 🇩🇪Germany @sun
Created by

🇮🇹Italy plach Venezia

Live updates comments and jobs are added and updated live.
  • D8MI

    (Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.

  • API addition

    Enhances an existing API or introduces a new subsystem. Depending on the size and impact, possibly backportable to earlier major versions.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    needs-review-queue-bot

    The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024