JeffM2001 → created an issue.
JeffM2001 → made their first commit to this issue’s fork.
JeffM2001 → created an issue.
The patch in #4 fixes this with All Day events, but actually breaks exclusions for events that aren't all day. This is because when generating occurrences rrule compares the exact timestamp of exdates to the occurrence, so if the time doesn't match it's not excluded.
I think a better solution is to check for the All Day toggle in transferStateToTempstore and set the correct start/end time if it is on.
I actually think this should also fix the issue in 🐛 Monthly mode works incorrect if use All day with empty time fields Needs work
JeffM2001 → created an issue.
Having a hook that alters the media_library_add_form_dropzonejs form is not really any different than altering the media_library_add_form_upload form. I just did it this way in order to not repeat code.
Perhaps it would look less weird if it was changed to a hook_form_alter() with a condition to check the form ids inside the function.
Re-rolling this patch for 2.x
JeffM2001 → created an issue.
I ran into an issue around this as well, and while I tend to agree it's too opinionated, I did find the original discussion of why these checks were added. It seems like useful context to have, if nothing else.
#3038254: Delegate media library access to the "thing" that opened the library → starting around comment 62