Re-rolling for latest dev.
So there are two different issues being solved by this patch, but the same lines of code are involved so it makes sense to fix them together.
The first issue is that if you create an all day recurring event with exclusions, the exclusions get stored with the original start/end times — which won't match the event times post save. Checking for the "all day" flag and normalizing the start/end times in transferStateToTempstore solves this.
The other issue is related to the seconds. Despite formElement() trying to set step to 1, the form element still ends up being rendered with step 60.
I'm not sure why that is, but it doesn't cause any problems except for all day events where the value is set with seconds by the validation. In Chrome, this doesn't affect anything (it just ignores the seconds), but in Safari it won't validate the input if the value is more granular than the step.
Figuring out why the step is 60 would be another way to solve this issue, but it doesn't seem necessary. Since all-day events aren't time based anyway, it makes no difference to have that extra granularity.
Reroll for 2.3.x
Rebase for 3.2.x
Can confirm that 🐛 The specified #ajax callback is empty or not callable. Fixed resolves this issue
Rebase for 3.2.x
FYI, if you're using the latest version of the MR in
✨
Third party should be allowed to alter the section render array
Needs work
the subscribed event needs to be changed to:
$events[SectionBuildRenderArrayEvent::SECTION_BUILD_RENDER_ARRAY] = ['onSectionBuildRender'];
This is still a problem we're having. I can't reproduce it locally, but it happens on Pantheon. I suspect that using a CDN makes a difference.
None of the patches in this thread are solving this issue for me on their own. This new patch is a combination of the approaches in #27 and #33, which is working for me if I also add patch #4 from crop 🐛 Crop API is not appending a hash when the image styles are converted to WEBP Needs review
Leaving status as Postponed, because I can't actually provide definitive steps to reproduce the issue or explain exactly what's happening. Just wanted to share what's working for me.
JeffM2001 → created an issue.
JeffM2001 → created an issue.
JeffM2001 → made their first commit to this issue’s fork.
JeffM2001 → created an issue.
The patch in #4 fixes this with All Day events, but actually breaks exclusions for events that aren't all day. This is because when generating occurrences rrule compares the exact timestamp of exdates to the occurrence, so if the time doesn't match it's not excluded.
I think a better solution is to check for the All Day toggle in transferStateToTempstore and set the correct start/end time if it is on.
I actually think this should also fix the issue in 🐛 Monthly mode works incorrect if use All day with empty time fields Needs work
JeffM2001 → created an issue.
Having a hook that alters the media_library_add_form_dropzonejs form is not really any different than altering the media_library_add_form_upload form. I just did it this way in order to not repeat code.
Perhaps it would look less weird if it was changed to a hook_form_alter() with a condition to check the form ids inside the function.
Re-rolling this patch for 2.x
JeffM2001 → created an issue.
I ran into an issue around this as well, and while I tend to agree it's too opinionated, I did find the original discussion of why these checks were added. It seems like useful context to have, if nothing else.
#3038254: Delegate media library access to the "thing" that opened the library → starting around comment 62