Sierra widget all day exclusions inconsistencies

Not sure related to it or not, however, we noticed. During creating a new node if the Event date is in the past or the future (not today) and the "All day" checkbox is enabled, after a custom rule https://take.ms/OUYIc, when opening the "Occurrences" widget the dates start from today in popup https://take.ms/d9Iwrd. Will have a look more and provide a patch or will open another issue.

Please ignore my comment #5. I found better issue for it https://www.drupal.org/project/date_recur_modular/issues/3188671 🐛 Monthly mode works incorrect if use All day with empty time fields Needs work .

The patch in #4 fixes this with All Day events, but actually breaks exclusions for events that aren't all day. This is because when generating occurrences rrule compares the exact timestamp of exdates to the occurrence, so if the time doesn't match it's not excluded.

I think a better solution is to check for the All Day toggle in transferStateToTempstore and set the correct start/end time if it is on.

I actually think this should also fix the issue in 🐛 Monthly mode works incorrect if use All day with empty time fields Needs work