In
#2474075: Fix Node::preSave() and document that preSave() and postSave() are not working with ContentEntity translations →
we agreed that we have an inconsistent API. While FieldItemListInterface::preSave() is called on every translation of a field, EntityInterface::preSave() is only called once on an entity before save, regardless of it's translations.
There're already exiting implementations of EntityInterface::preSave() that should not run multiple times per save. If we simply call EntityInterface::preSave() on every translation of en entity, these implementations need a switch to just be active on the default translation.
Therefor @catch proposed to consider to split this method into two. One that will be executed once and another that will be executed on every translation of the entity before save.
Decide about the best API.
None.
Sure ;-)
None.
Needs work
10.1 ✨
(Drupal 8 Multilingual Initiative) is the tag used by the multilingual initiative to mark core issues (and some contributed module issues). For versions other than Drupal 8, use the i18n (Internationalization) tag on issues which involve or affect multilingual / multinational support. That is preferred over Translation.
Enhances an existing API or introduces a new subsystem. Depending on the size and impact, possibly backportable to earlier major versions.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
MR has a bunch of failures.
And was previously tagged for tests which still needs to happen.