Does the version constraint in composer.json need to be updated also?
This worked for us as well.
I updated the test as I think this is an expected change since its using a core-provided image style (thumbnail): https://www.drupal.org/node/3421405 →
It looks like there are a couple test failures compared with the 2.x branch that need to be fixed: https://git.drupalcode.org/issue/remote_stream_wrapper-3437974/-/jobs/18...
That fixed the error on install but images were not rendering for me. I added the required_derivative_scheme route config based on
https://www.drupal.org/node/3346038 →
and its working now.
richardbporter → created an issue.
Where was this documented?
There was a possibly related issue I mentioned in https://www.drupal.org/project/linkit/issues/3158783#comment-14461927 🐛 Links around media images break when edited, using Linkit and CKeditor Needs review that may have fixed this.
A background color class might want to be applied to a specific block or an entire section.
Update append example to reference robots.txt instead of incorrect .htaccess
Sorry, I was incorrect. There is a line break in the translated string which makes it difficult to translate. I applied the patch in an MR, adjusted the code style for readability and updated the return type of getPolicyLinks. Worked for me locally. Thanks!
richardbporter → created an issue.
richardbporter → made their first commit to this issue’s fork.
Tested this locally and fixed a couple PHPCS issues.
I believe this was fixed in https://www.drupal.org/node/3353994 → and committed to the 1.x-dev branch.
This would be useful to have in the logs. MR looks good to me.
Any update on this? Is this module still actively maintained?
I think the $result->setCacheMaxAge(0); is unnecessary and will break page cache. Setting the entity context_definitions in the block configuration seemed like it was required for caching to work properly:
The test failures are seemingly unrelated as they're failing on another issue as well. The `HtmlTitleDraftTest` is passing based on the job logs: https://git.drupalcode.org/issue/html_title-3241474/-/jobs/581937. Marking as RTBC.
I applied the patch from #5 in a new MR and made one more fix. I'm not seeing anymore PHPCS violations.
richardbporter → made their first commit to this issue’s fork.
The patch worked for us. I updated the MR to fix the test failures and add another assertions for the original title.
richardbporter → made their first commit to this issue’s fork.
Started an MR with the patch applied and the URL targeting v1 - required updating how the score is accessed in the API response.
Also the url that's constructed is pointing to the site secret and for enterprise it should be pointing to the site key instead.
@oheller - can you clarify this?
We needed the ability to restrict token generation by role and the MR seems to do just that.
mcdruid → credited richardbporter → .
Rerolled #25 for 8.x-1.9.
This sounds what is described in https://git.drupalcode.org/project/pantheon_advanced_page_cache#changing.... Have you tried that?
This should be resolved with https://www.drupal.org/project/bynder/issues/3259406 🐛 Compact UI hard-coded to use MultiSelect when cardinality only allows single items RTBC
It might be good to get an initial review to confirm this is the right direction before going further.
I had started working on this separately and then found this issue. Since it hadn't been updated in a while, I pushed some commits to keep it moving.
There are probably more UX improvements, validation and select2 doc references that could be made to the settings form. Test coverage would be good also.
richardbporter → made their first commit to this issue’s fork.