Fix the warnings/errors reported by PHP_CodeSniffer

FILE: ...enovo/d7to9/web/modules/contrib/simple_recaptcha/modules/simple_recaptcha_webform/src/Plugin/WebformHandler/SimpleRecaptchaWebformHandler.php --------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES --------------------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface. 56 | WARNING | [x] A comma should follow the last multiline array item. Found: FALSE --------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/src/SimpleReCaptchaFormManager.php ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 353 | WARNING | Unused variable $isstring. ------------------------------------------------------------------------------------------------ FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/css/hide_badge.css -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | ERROR | [x] Opening brace should be the last content on the line 1 | ERROR | [x] Expected 1 newline at end of file; 0 found 1 | ERROR | [x] Closing brace of class definition must be on new line -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/tests/src/Functional/SimpleRecaptchaTest.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/tests/src/Unit/SimpleReCaptchaFormManagerTest.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\simple_recaptcha\SimpleReCaptchaFormManager. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/tests/src/FunctionalJavascript/SimpleRecaptchaJavascriptTestBase.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 45 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------- FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/tests/src/FunctionalJavascript/SimpleRecaptchaJavascriptTest.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 43 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /home/lenovo/d7to9/web/modules/contrib/simple_recaptcha/simple_recaptcha.libraries.yml -------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------- 31 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------- Time: 192ms; Memory: 12MB

Comments & Activities

Issue created by @roshni27
Issue was unassigned.
Status changed to Needs review over 1 year ago3:02pm 11 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30 pass, 4 fail
Comment over 1 year ago →
🇮🇳India roshni27
Comment over 1 year ago →
System Message
The last submitted patch, 2: fixes-error-phpcs-3373916-2.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update over 1 year ago
30 pass, 4 fail
Open in Jenkins → Open on Drupal.org →
Core: 10.1.4 + Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
30 pass, 4 fail
Comment about 1 year ago →
🇮🇳India Ashutosh Ahirwal India
Providing updated patch with phcs fixes.
Please review.
Comment about 1 year ago →
System Message
The last submitted patch, 4: phpcs-issue-fixes-3373916-4.patch, failed testing. View results →
Status changed to Needs work about 1 year ago9:06am 4 October 2023
Comment about 1 year ago →
🇮🇳India aayushDrupal
Hi Ashutosh Ahirwal,
Patch #4 has been successfully applied, resolving all PHPCS errors. Please refer to the attached screenshot for your reference.

Moving to RTBC.
Thank you.
Status changed to RTBC about 1 year ago9:06am 4 October 2023
Comment about 1 year ago →
🇮🇳India aayushDrupal
Status changed to Needs work about 1 year ago10:43am 9 October 2023
Comment about 1 year ago →
🇵🇱Poland sandboxpl Poland 🇵🇱
The provided patch is breaking the tests,
please check tests output at https://www.drupal.org/pift-ci-job/2777420 →
Assigned to mohd sahzad
Comment about 1 year ago →
🇮🇳India mohd sahzad
Issue was unassigned.
Comment about 1 year ago →
🇮🇳India mohd sahzad
I have updated this issue : Fix the warnings/errors reported by PHP_CodeSniffer
First commit to issue fork.
Merge request !18Resolve #3373916 "Fix the warningserrors" → (Open) created by richardbporter
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
38 pass
Status changed to Needs review 10 months ago9:18am 17 January 2024
Comment 10 months ago →
🇮🇳India zkhan.aamir
Hi,

I applied MR #12 and it applied successfully. All the error have been resolved.

Please refer screenshot.
Status changed to RTBC 10 months ago3:39pm 17 January 2024
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 5.7
last update 10 months ago
30 pass, 4 fail
Comment 10 months ago →
🇺🇸United States richardbporter
Comment 10 months ago →
System Message
The last submitted patch, 10: Fix-the-warnings-errors-reported-by-PHP_CodeSniffer-3373916-5.patch, failed testing. View results →

Fix the warnings/errors reported by PHP_CodeSniffer

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!18Fix the warnings/errors reported by PHP_CodeSniffer
Open

Comments & Activities

Fix the warnings/errors reported by PHP_CodeSniffer

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!18Fix the warnings/errors reported by PHP_CodeSnifferOpen

Comments & Activities

!18Fix the warnings/errors reported by PHP_CodeSniffer
Open