Block - #lazy_builder content is empty for admin user on refresh

Thanks for contributing the patch. Could you create as an MR please so tests run? Thanks!

I'm not quite familiar with the placeholder bit; if you could explain why it works that would be great as well.

I've tried to replicate the issue but can't.
Could you please provide proper reproducing steps with configuration?

Despite of rasing MR for tests...

I had the same problem. The patch worked for me. The problem appears for all users that are logged in - but not for anonymous users

Thanks everyone for the help here thus far.

Hmmm the description of the problem and the documentation I can find on create_placeholder makes me worry we are bandaging a symptom rather than solving a problem. I cannot reproduce this, but I believe the root issue is that the FootnotesGroup::buildFooter() render array is not given any cache context so it does not vary in the same way as the block does.

I have created a 2nd MR in branch '3475513-lazy-builder-cache' which instead adds #cache to the render array.

Can one of you having the issue please check if this branch also solves the issue please? Would be much appreciated!

this does not solve the problem. The patch above does.

Thanks for checking. But nervous to commit something I don't understand bug reading https://www.drupal.org/node/2498803 → it seems the key thing is that the response remains cacheable. So I'll check that and if still cache hit on 2nd load then it seems does no harm.

Thanks for your support!

scott_euser → changed the visibility of the branch 3475513-lazy-builder-cache to hidden.

okay - ready to try any other fix!

Just going through this testing, I wonder if you are missing this bit in your block configuration?

Okay I managed to reproduce, and yep even with that context it still disappears on second load.
With the original patch/MR there is a Drupal Dynamic Cache HIT in the headers still on second load when logged in, so works for me!

Thank you everyone!

(Gitlab merging is failing, so merged locally, its on the 4.0.x branch, no release yet)

scott_euser → closed merge request !60

Automatically closed - issue fixed for 2 weeks with no activity.