Account created on 4 April 2014, about 10 years ago
#

Merge Requests

Recent comments

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Adding patch file for current changes in the Gitlab merge request,

πŸ‡¬πŸ‡§United Kingdom stephen-cox

There's now a merge request implementing this with tests.

There are pull requests to add this functionality to LocalGov Drupal:

πŸ‡¬πŸ‡§United Kingdom stephen-cox

A fair amount of work has been done to internationalize LocalGov Drupal as it's being used by a number of Irish councils.

Dev for this is happening here: https://github.com/localgovdrupal/localgov_multilingual

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Thanks for catching this @ressa. Development happens on GitHub and we recommend installing LocalGov Drupal using the Composer `localgovdrupal/localgov_project` package, so the drupal.org page and git repo doesn't get updated as often as it could.

I have updated the default branch to 3.x.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Great to see an admin UI for this. Any chance of a new release including this?

The admin UI is useful for use as part of this issue https://github.com/localgovdrupal/localgov/issues/600. As an interim I've created a PR to use the dev branch (https://github.com/localgovdrupal/localgov/pull/691), but would be nice if we didn't have to reference specific commits in the dev branch.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

This is fixed in the latest 2.x release.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Module now has Drupal 10 support!

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Merged this so the module now has D10 support.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

stephen-cox β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Maybe a different problem, but I'm seeing this. Lots of text in a paragraph item pushes the save button off the bottom of the screen meaning it's not possible to save the page.

Patch #6 didn't fix this issue. The following CSS rule fixed it for me:

.layout-paragraphs-component-form .ck-editor__main > .ck-editor__editable {
  max-height: calc(100vh - 320px);
}
πŸ‡¬πŸ‡§United Kingdom stephen-cox

It looks to me like the hook_toolbar_alter implementation was added as part of #3176679 β†’ and has always contained the error causing this issue.

Added fix for this.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

stephen-cox β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Previous patch didn't work. New patch re-rolled against latest 2.x branch.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

I've merged this into the 5.0.x branch and created a 5.0.0-alpha1 release with Drupal 10 support.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Patch containing the same changes as the issue fork.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Re-rolled patch against latest 2.2.2 release.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

We have the changes on the issues fork https://git.drupalcode.org/issue/responsive_menu-3297964/-/tree/3297964-... are working on a number of sites without issue.

Would be great if we can get a dev release with this at a minimum so we don't have to keep using the issue fork to install it.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

stephen-cox β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

We've been using Domain Group 3.x with LocalGov Microsites (https://github.com/localgovdrupal/localgov_microsites) for a while now and there are a few production sites built on the platform.

Can we get a proper release out for this? It would be good to start tracking a beta tag rather than individual commits.

Live sites:

πŸ‡¬πŸ‡§United Kingdom stephen-cox

@aaon.ferris I have created a new release for this on drupal.org, https://www.drupal.org/project/localgov/releases/2.3.19 β†’ , but as you've seen this lags behind GitHub as that's were development is done.

I recommend you update your composer.json file to use `localgovdrupal/localgov` rather than `drupal/localgov`.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

I've also tested this and it works well.

Currently exported domain config is kept while the config for new sites is ignored.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

Issue with the footnotes block looks to be due to the cache keys not being set correctly. I've added cache keys, tags and context to the render array built by the FootnotesGroupBlock which fixes the cache issue for me.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

stephen-cox β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

It looks like the issue is the group_term view. Attached patch is a complete rebuild of this view and looks to solve the problem.

I can push to this to the issue fork, but I don't seem to have permission to do this.

πŸ‡¬πŸ‡§United Kingdom stephen-cox

stephen-cox β†’ made their first commit to this issue’s fork.

Production build 0.69.0 2024