🇬🇧United Kingdom @stephen-cox

+1

+1

:+1:

> try adding container_rebuild_required: true to modules/localgov_media/localgov_media.info.yml

Unfortunately, this doesn't seem to fix things - I've tried adding `container_rebuild_required: true` to all the LocalGov Drupal modules loaded in the tests and they still fail. Using Xdebug to check when hook_modules_installed is called, it looks like config dependencies are calculated before this hook whether `container_rebuild_required` is true or not.

stephen-cox → created an issue.

I've done a bit more digging into this. The LocalGov Media module uses hook_modules_installed to force the install of the optional config in the module (https://git.drupalcode.org/project/localgov_core/-/blob/2.x/modules/loca...), but this hook is not being called before the dependencies for the config in localgov_homepage_paragraphs are being calculated. Which means the config validation is failing.

It's clearly not good to have config that is going to be installed rely on optional config. The reason it currently works this way is much of the config in the media module is copied from the standard profile and would cause errors if the module was enabled with this profile rather than the LocalGov profile.

Ideally, we would want to delay the calculation of dependencies for some modules until after others are enabled. `container_rebuild_required: true` doesn't seem to be doing this.

Looking at a single test: https://git.drupalcode.org/project/localgov_paragraphs/-/blob/2.x/module...

This fails on Drupal 11.2 with:

Drupal\Core\Config\UnmetDependenciesException: Configuration objects provided by localgov_homepage_paragraphs have unmet dependencies: field.field.paragraph.localgov_featured_campaign.localgov_featured_campaign_image (media.type.image)

The media.type.image config item is provided by the localgov_media module (https://git.drupalcode.org/project/localgov_core/-/blob/2.x/modules/loca...), but is optional config. Moving the YML file into the install directory fixes the test; all config items install without any errors.

Has the way optional config is installed changed? It certainly seems that optional config is not being installed when it should be.

+1

stephen-cox → created an issue.

+1

+1

finn lewis → credited stephen-cox → .

+1

+1

+1

+1

+1

+1

+1

+1

Closing this as I'm not going to add inverse permissions to this module.

stephen-cox → made their first commit to this issue’s fork.

stephen-cox → created an issue.

Adding patch of the current state MR.

stephen-cox → created an issue.

aaron.hirtenstein → credited stephen-cox → .

+1 for these changes. I spent hours trying to get this working until I came across this issue.

finn lewis → credited stephen-cox → .

I had this issue on a fresh D11 install after enabling Gin Toolbar and the patch fixes it.

I also needed to patch Gin with https://www.drupal.org/project/gin/issues/3511415 🐛 Edge case: $settings->get('enable_darkmode') can cause WSOD Active

I had this issue on a fresh D11 install after enabling Gin and the patch fixes it.

finn lewis → credited stephen-cox → .

finn lewis → credited stephen-cox → .

Patch #3 doesn't apply properly. Uploading on that does.

markconroy → credited stephen-cox → .

The attached patch contains the same changes as the MR.

stephen-cox → created an issue.

finn lewis → credited stephen-cox → .

finn lewis → credited stephen-cox → .

finn lewis → credited stephen-cox → .

There's another report of this happening https://github.com/localgovdrupal/localgov/issues/809#issue-2804204272, but I've been unable to reproduce it with a clean install of Drupal or LocalGov Drupal.

Patch #1 doesn't cleanly apply to the 3.0.x branch. The attached patch is the current state of MR !22 and should work with 8.x-2.x and 3.0.x.

I'm here!

finn lewis → credited stephen-cox → .

Merge requests now have conflicts. Attached patch includes all the changes needed to D11 compatibility.

Thanks for the bug report and patch. This is a duplicate of #3404945 which is now fixed.

Thanks all. Fixed with https://git.drupalcode.org/project/responsive_menu/-/commit/e1b5013e4345...

Merged and marking fixed. Thanks @kelly.m.jacobs

stephen-cox → made their first commit to this issue’s fork.

stephen-cox → created an issue.

stephen-cox → created an issue. See original summary → .

finn lewis → credited stephen-cox → .

finn lewis → credited stephen-cox → .

Patch #9 fixed this issue for me. Without it images with special characters were redirecting to themselves and so weren't loading.

I've also created a MR which contains the patch with a small whitespace fix.

stephen-cox → made their first commit to this issue’s fork.

I have created a MR and patch that checks whether the entity being accessed is part of the preview link rather than the entity being viewed. This allows unpublished referenced entities that are included in the preview link to be viewed. There's an updated test for this as well.

The issue adding the functionality causing problems here is https://www.drupal.org/project/preview_link/issues/3117258 →

stephen-cox → created an issue.

greggles → credited stephen-cox → .

Adding patch file for current changes in the Gitlab merge request,

There's now a merge request implementing this with tests.

There are pull requests to add this functionality to LocalGov Drupal:

• Patch Preview Link: https://github.com/localgovdrupal/localgov/pull/713
• Add a plugin to Guides: https://github.com/localgovdrupal/localgov_guides/pull/163
• Add a plugin to Step-by-steps: https://github.com/localgovdrupal/localgov_step_by_step/pull/98

A fair amount of work has been done to internationalize LocalGov Drupal as it's being used by a number of Irish councils.

Dev for this is happening here: https://github.com/localgovdrupal/localgov_multilingual

Thanks for catching this @ressa. Development happens on GitHub and we recommend installing LocalGov Drupal using the Composer `localgovdrupal/localgov_project` package, so the drupal.org page and git repo doesn't get updated as often as it could.

I have updated the default branch to 3.x.

stephen-cox → created an issue.

Great to see an admin UI for this. Any chance of a new release including this?

The admin UI is useful for use as part of this issue https://github.com/localgovdrupal/localgov/issues/600. As an interim I've created a PR to use the dev branch (https://github.com/localgovdrupal/localgov/pull/691), but would be nice if we didn't have to reference specific commits in the dev branch.

stephen-cox → created an issue.

stephen-cox → created an issue.

This is fixed in the latest 2.x release.

This is fixed in the latest 2.x release.

Module now has Drupal 10 support!

Merged this so the module now has D10 support.

stephen-cox → made their first commit to this issue’s fork.

Maybe a different problem, but I'm seeing this. Lots of text in a paragraph item pushes the save button off the bottom of the screen meaning it's not possible to save the page.

Patch #6 didn't fix this issue. The following CSS rule fixed it for me:

.layout-paragraphs-component-form .ck-editor__main > .ck-editor__editable {
  max-height: calc(100vh - 320px);
}

It looks to me like the hook_toolbar_alter implementation was added as part of #3176679 → and has always contained the error causing this issue.

Added fix for this.

stephen-cox → made their first commit to this issue’s fork.

Previous patch didn't work. New patch re-rolled against latest 2.x branch.

I've merged this into the 5.0.x branch and created a 5.0.0-alpha1 release with Drupal 10 support.

Patch containing the same changes as the issue fork.

stephen-cox → created an issue.

Re-rolled patch against latest 2.2.2 release.

We have the changes on the issues fork https://git.drupalcode.org/issue/responsive_menu-3297964/-/tree/3297964-... are working on a number of sites without issue.

Would be great if we can get a dev release with this at a minimum so we don't have to keep using the issue fork to install it.

stephen-cox → made their first commit to this issue’s fork.

We've been using Domain Group 3.x with LocalGov Microsites (https://github.com/localgovdrupal/localgov_microsites) for a while now and there are a few production sites built on the platform.

Can we get a proper release out for this? It would be good to start tracking a beta tag rather than individual commits.

Live sites:

• https://jobs.oxfordshire.gov.uk/
• https://investwalthamforest.com/
• https://www.haringeyfeast.com/
• https://northeastcommunityforest.org.uk/

@aaon.ferris I have created a new release for this on drupal.org, https://www.drupal.org/project/localgov/releases/2.3.19 → , but as you've seen this lags behind GitHub as that's were development is done.

I recommend you update your composer.json file to use `localgovdrupal/localgov` rather than `drupal/localgov`.

Thanks for the patch @aaron.ferris

PR for this here: https://github.com/localgovdrupal/localgov/pull/587

I've also tested this and it works well.

Currently exported domain config is kept while the config for new sites is ignored.