- Issue created by @flocondetoile
- Status changed to Needs review
over 1 year ago 2:49pm 29 November 2023 - last update
over 1 year ago 16 pass, 1 fail The last submitted patch, 2: 3404945-2.patch, failed testing. View results โ
- ๐ฎ๐ณIndia chetan 11
chetan 11 โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
over 1 year ago Waiting for branch to pass - ๐ฎ๐ณIndia chetan 11
Hi,
I have fixed the above error on the "Responsive and off-canvas menu" module.
Please check the raised MR.
Thanks. - ๐ฌ๐งUnited Kingdom alt36
The patch in #3404945-2: Uncaught TypeError: Drupal.toolbar is undefined โ looks good to me. I note that that patch upload has a failing test at ResponsiveMenuAdminTest::testPolyfillsInclusion but that's unrelated to this change. (Separately see ๐ Fix failing test Needs review which proposes removing that failing test)
- ๐ฌ๐งUnited Kingdom natuk Cymru
Thank you, the patch from #2 fixes the problem.
- ๐ญ๐บHungary czigor
Patch #2 makes sense and fixes the issue for me as well.
- ๐ฌ๐งUnited Kingdom grzesag
Patch #2 should be required as since Drupal 10.4.x and 11.1.x the asset ordering is now more strictly determined by library dependencies (see the Drupal 10.4 change log) https://www.drupal.org/node/3473558 โ
On the Drupal instance I updated to 10.4.0 adding the dependencies as in patch #2 fixed our problems
- ๐บ๐ธUnited States mortona2k Seattle
mortona2k โ changed the visibility of the branch 3404945-uncaught-typeerror-drupal.toolbar to hidden.
- ๐ฌ๐งUnited Kingdom retrodans
Patch #2 also helped me with a bug whilst updating to Drupal 10.4.1
@stephen-cox can I help to get this merged in?
-
stephen-cox โ
committed e1b5013e on 4.4.x
Issue #3404945 by flocondetoile: Uncaught TypeError: Drupal.toolbar is...
-
stephen-cox โ
committed e1b5013e on 4.4.x
- ๐ฌ๐งUnited Kingdom stephen-cox
Thanks all. Fixed with https://git.drupalcode.org/project/responsive_menu/-/commit/e1b5013e4345...
- Status changed to Fixed
2 months ago 1:54pm 18 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.