- Issue created by @tanc
- First commit to issue fork.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 8last update
over 1 year ago Waiting for branch to pass - @aangel opened merge request.
- 🇺🇸United States aangel
I was able to reproduce the error locally. The test is failing because it is checking for the addition of the polyfills script to the page. The problem is that the latest version of the mmenu library does not include that file.
The file may be missing simply due to a compilation error over at mmenu, which has happened at least twice before that I could find (https://github.com/FrDH/mmenu-js/issues/1183 and https://github.com/FrDH/mmenu-js/issues/1146). The maintainer re-compiled and it came back.
There are two ways forward.
I can ask the maintainer to add the polyfill file back. Or, given that D10 is no longer supporting IE, I've created an MR with the polyfill logic for the config, the form and test removed. I'm not attached to either direction and you will have a better idea if the polyfill needs to stick around longer.
- Status changed to Needs review
over 1 year ago 9:30pm 19 August 2023 - 🇺🇸United States aangel
Just spotted this in the README of mmenu:
Browser support
As of version 9, the mmenu.js plugin only supports ECMAScript 6 compliant browsers.
For Internet Explorer 11, you can use the latest of version 8 and use polyfills where needed.So there doesn't seem to be an intention of allowing the 9.x branch with polyfills.