πŸ‡¬πŸ‡§United Kingdom @retrodans

Account created on 20 April 2008, about 16 years ago
#

Recent comments

πŸ‡¬πŸ‡§United Kingdom retrodans

Just to say I have seen this in a couple of other places, and this helped resolve most uses of `addDelayedEvent` I have seen.

πŸ‡¬πŸ‡§United Kingdom retrodans

Just needed a few variable setters. Patch attached

πŸ‡¬πŸ‡§United Kingdom retrodans

@sagesolutions thanks for the comments, I have made amends for 1/2/3

I haven't done 4 though, as not sure whether I know enough about it to implement the change. A lot of this was already there from one of the early patches in comment #9, I just refactored for the newest branch. I can see it is being added as a KernelEvent, and imagine there was a reason it was put here rather than using one of the cart hooks, why was that? As before I mess with conditions, it might be good to understand why it is a Kernel event.

πŸ‡¬πŸ‡§United Kingdom retrodans

retrodans β†’ made their first commit to this issue’s fork.

πŸ‡¬πŸ‡§United Kingdom retrodans

We wanted to try out this patch, but it wouldn't apply to beta or dev for me. So I have refactored a patch to work for 2.0.0-beta1 and figured it might be worth sharing in case others want to test this out to help. I am afraid it doesn't take into account the ideas since comment #36, as was just a refactor.

Production build 0.69.0 2024