Patch #2 also helped me with a bug whilst updating to Drupal 10.4.1
@stephen-cox can I help to get this merged in?
retrodans → created an issue.
What is the best process to get this looked at other than just the patch? Do I need to create a fork, or notify someone? We are using this on a few sites reliably now, so would be good to either merge it in, or understand why it isn't going to be merged in (so we can change the fix).
retrodans → created an issue.
To note, in our sandbox account, if I created a brand new business user, and then a brand new app for that user, it works. So there is something wrong with the app/user rather than this module. But I think the feedback from the module could help with debugging it.
retrodans → created an issue.
Just to add a note, on a site we are using we have:
- Editor Advanced link 2.2.4
- Editor File upload 2.0.0-rc1
The issue we had is that none of the values in advanced were getting saved.
Patch #7 solved this issue, whilst patch #11 did not.
And this is the workaround which also removes the defer
This is the patch file to add the minify flag, which would be good to merge in
retrodans → created an issue.
Just to say I have seen this in a couple of other places, and this helped resolve most uses of `addDelayedEvent` I have seen.
Just needed a few variable setters. Patch attached
retrodans → created an issue.
@sagesolutions thanks for the comments, I have made amends for 1/2/3
I haven't done 4 though, as not sure whether I know enough about it to implement the change. A lot of this was already there from one of the early patches in comment #9, I just refactored for the newest branch. I can see it is being added as a KernelEvent, and imagine there was a reason it was put here rather than using one of the cart hooks, why was that? As before I mess with conditions, it might be good to understand why it is a Kernel event.
retrodans → made their first commit to this issue’s fork.
We wanted to try out this patch, but it wouldn't apply to beta or dev for me. So I have refactored a patch to work for 2.0.0-beta1 and figured it might be worth sharing in case others want to test this out to help. I am afraid it doesn't take into account the ideas since comment #36, as was just a refactor.