Group 3.x compatible version

Created on 8 November 2022, about 2 years ago
Updated 5 September 2023, about 1 year ago

Problem/Motivation

Group 2.x and 3.x are the new versions of Group module. 2.x is an upgrade path module that still uses the machine name for group content that 1.x uses. 3.x is the same as 2.x except updating entity machine name.

Make a 3.x compatible version. Maybe backport a 2.x version.

Proposed resolution

Update the module for API changes as https://www.drupal.org/docs/contributed-modules/group/updating-your-modu...

There is a new access system, but this doesn't - yet - allow denying access in the entity query.
Quoting from Slack:

I'm thinking of invoking an alteration layer with the refinable permissions and calculator service name for each invoked calculator. That should make it easier for the alteration layer to find what you need. We should also consider a catch-all alteration at the end of the chain for "blanket access revokes", regardless of which calculator granted the access.

So continuing the work on https://www.drupal.org/project/domain_group/issues/3276172 works for all relationship entities correctly for now, but could be integrated further in the future.

Extend and updating testing.

Remaining tasks

Work has been done in https://git.drupalcode.org/sandbox/ekes-3278349/-/tree/group-3.x

Propose to make a new branch and version of this module for Group 3.x support... potentially 4.x if Group 2.x support is to also be made (that would then be 3.x).

The LocalGov Drupal would be happy to maintain the Group 3.x compatible version, as we're using it for Microsites. That would be at the moment Drupal users ekes , Finn Lewis , stephen-cox .

📌 Task
Status

Needs review

Version

2.0

Component

Code

Created by

🇳🇱Netherlands ekes

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇳🇱Netherlands ekes

    @jidrone I'll merge this sandbox as a branch into the main domain_group repo, assuming I now have the privs. I'm thinking it should just be a 3.x version and branch. I can bring the tags along with it too?

  • Status changed to Needs work over 1 year ago
  • 🇨🇴Colombia jidrone

    I think you can push the 3.x dev branch and once we test it is working we can create 3.0.x-beta1 tag.

  • Status changed to Needs review over 1 year ago
  • 🇳🇱Netherlands ekes

    Pushed.

    Couple of pointers:

    If you've not used it much yet (or even if you have - it still catches me out) watch out for the Group 3.x gotcha where User 1 doesn't by default get any permission to groups (like you can't even see them even though you created them if you not set up the permissions). User 1 is just not special for Group permissions.

    Another one on the permissions once you have a domain group. All content that's in the group has access control on the domain. It's not just node_access. So for example you won't see users that aren't members of group_1 in domain 1.

  • 🇬🇧United Kingdom Finn Lewis

    Hey @jidrone and @fabiansierra5191

    We're starting to want to create issues agains the 3.x version, please could we get a 3.x branch that we can put issues against and help to support?

    Many thanks,

    Finn

  • 🇨🇴Colombia jidrone

    I just did it, sorry for the delay.

  • 🇬🇧United Kingdom stephen-cox

    We've been using Domain Group 3.x with LocalGov Microsites (https://github.com/localgovdrupal/localgov_microsites) for a while now and there are a few production sites built on the platform.

    Can we get a proper release out for this? It would be good to start tracking a beta tag rather than individual commits.

    Live sites:

Production build 0.71.5 2024