Toolbar alter hook overwrites pre render callbacks completely

It looks to me like the hook_toolbar_alter implementation was added as part of #3176679 → and has always contained the error causing this issue.

Added fix for this.

Liam Morland → made their first commit to this issue’s fork.

I made a merge request with patch #3.

The change is simple and clean. Setting it as RTBC.

You still need to remove Drupal\admin_toolbar\Render\Element\AdminToolbar::preRenderTray(), otherwise the whole administration menu is built twice, which is a waste of time and resources.

I wonder whether this is in the scope of this issue...
I did update the issue summary with your remarks though.

Of course it is, because if you’re committing the MR as it is now you’re introducing a performance issue. It’s not a difficult problem to fix.