Order of toolbar menu items is changed after updating to 1.0.0-beta18

Thank you jrb → .

I patched gin and gin_toolbar and the menu works again like expected. It took me a bit of time until i found the reason, why the core functionality does not work any more – and how to solve it. :-(

In my opinion this change should have been (better) documented.
Even worse: I have a custom module which introduces a new menu-item which should be the last element in the row. That didn't work, too.

Imho this behavior should be removed or at least be optional (like with the patches).

Patch still applies

This needs to be committed (and the Gin patch) and the default for it to be disabled/do not change behaviour - changing the behaviour of the menu and breaking core functionality without notice is not something that should be happening in a contrib module.

If there is a wonderful reason backed by A/B to re-arrange the ordering then it should be in core that it happens and this module should be respecting the settings of the menu and not silently overriding them.

@ELC I have to disagree here. Gin was created as an extension to Claro for us to explore how the Admin UI in Core potentially will look like in the future and to run A/B (and other tests) out in the wild for stuff which is out of scope for Claro/Core or needs to be verified first.

This needs to be committed (and the Gin patch) and the default for it to be disabled/do not change behaviour - changing the behaviour of the menu and breaking core functionality without notice is not something that should be happening in a contrib module.

Gin does alter quite some things where a traditional theme or module would not and that's okay for the purpose of what Gin tries to achieve.

If there is a wonderful reason backed by A/B to re-arrange the ordering then it should be in core that it happens and this module should be respecting the settings of the menu and not silently overriding them.

Gin is a big ongoing A/B test if you will (still) 😅. Quite some things made the jump over to Claro and more to follow but we're still using Gin as a testbed for Core. We're sorry if this caused any inconvenience on your (and others) end. As a quick solution you can use the patch from above.

Rebased to current HEAD.

Since this doesn't impact the existing default functionality but provides a way for admin to fix their menu order, it would be ideal if this could be merged in. Having to patch it in when it would not break the upstream seems unfortunate.