🇩🇪Germany @tfranz

I tested the patch #17 and can confirm, that it solves the problem on my `browser adaptive screen testing feature`.

I tested and use Patch #116 on one of our projects (Drupal 10.3.5) and it so far solved the problem, that we could not change and save older translated content with paragraphs.

I added a small icon for the toolbar.

seantwalsh → credited tfranz → .

Add link to module page.

I added a config link to the .info.yml

tfranz → made their first commit to this issue’s fork.

Thank you very much - I am grateful for your help …

I can confirm that the error-message is selectable.

tfranz → created an issue.

I have the same problem. Using the patch in https://www.drupal.org/project/linkit/issues/3363992 💬 Update module erroneously recommends conflicting update to 6.1.x for sites on Drupal 10.0.x or lower Closed: works as designed and changing the value for the 'exisiting_version' to '6.0.1' solved this for me:

- if (floatval($core) < 10.1 && ($projects['linkit']['existing_version'] === '6.0.0')) {
+ if (floatval($core) < 10.1 && ($projects['linkit']['existing_version'] === '6.0.1')) {

Patch added.

tfranz → created an issue.

Added patch.

tfranz → created an issue.

Okay, i was too quick. The output looks fine, but the single images won't resize: the collage is build with the original-sized (big) images.
And i can't get the modal gallery to work ... :-(

@Sahana _N: Thank you for your work and the patch!
I made some further enhancements to get it work with Drupal ^9 | 10.0. See the attached file "changes_patch_1-4.diff ".

I didn't test it very well, but at least i can use it with my installation of Drupal 10.0.9.

@shevgeny: I had your problem, too, and solved it.

Please review the patch.

Thank you – i tried the new branch and it seems to work for me (Drupal10.0.9).

I have some small changes:

1. I think we don't need the png-icons. As far as i can see, you can delete them including the folder "hidpi".
2. I removed the dependency to drupal:ckeditor
3. The translations couldn't be found, because the "interface translation server pattern" in shy.info.yml is wrong. It should be:
interface translation server pattern: modules/contrib/%project/translations/%language.po
4. And the translations are wrong. The "msgid" is "Replaces <shy></shy> tag with non-breaking space."

Another thing - the modules description:
Minimal module to insert a soft hyphen into the content by pressing Ctrl+Hyphen or using the provided button.
At least for me the keys "Ctrl+Hyphen" don't work.

Thank you for the patch – seems to work for me!

tfranz → created an issue.

Thank you for the patch!
I can confirm the missing values in Drupal 10.0.9. With this (and other patches from this issue 📌 Apply width and height attributes to allow responsive image tag use loading="lazy" Fixed ) it works: Width and Height are back again.

My patches:

  "patches": {
    "drupal/core": {
      "Order image mappings by breakpoint ID and numeric multiplier": "https://www.drupal.org/files/issues/2022-05-19/3267870-9.5.x-47.patch",
      "3192234: Apply width and height attributes to responsive image tag": "https://www.drupal.org/files/issues/2023-04-07/3192234-293-10.0.x.patch",
      "3359421: (Re-)Add width / height also on fallback image": "https://www.drupal.org/files/issues/2023-05-10/3359421-8.patch"
    },

@rgpublic: Yes, i think you should be right, but i haven't tested it.

It should not break anything, but at least it could simply ignore the old modules template <span class="shy">&#173;</span>. The new one is <shy>&shy;</shy>.
Or it could be that a new filter of CKEditor5 strips out the old tag and removes it completely. Then all old markups are lost.

But it would be nice, if the new module could take care of the old script, too.

I can confirm the patch removes the issue.

Thank you jrb → .

I patched gin and gin_toolbar and the menu works again like expected. It took me a bit of time until i found the reason, why the core functionality does not work any more – and how to solve it. :-(

In my opinion this change should have been (better) documented.
Even worse: I have a custom module which introduces a new menu-item which should be the last element in the row. That didn't work, too.

Imho this behavior should be removed or at least be optional (like with the patches).

Thank you!
I think this should go into a new version (2.0.0 ?), because it is not backwards-compatible.

tfranz → created an issue.

/**
 * Implements hook_theme_registry_alter().
 */
function MYMODULE_theme_registry_alter(&$info) {
    $info['TEMPLATE']['theme path'] = \Drupal::moduleHandler()->getModule("MYMODULE")->getPath();
    $info['TEMPLATE']['path'] = \Drupal::moduleHandler()->getModule("MYMODULE")->getPath() . '/templates';
}

I got this error, too:

[ERROR] Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator::__construct(): Argument #1
         ($container) must be of type Symfony\Component\DependencyInjection\ContainerBuilder,
         RectorPrefix202302\Symfony\Component\DependencyInjection\ContainerBuilder given, called in
         /var/www/html/vendor/rector/rector/vendor/symfony/dependency-injection/Loader/PhpFileLoader.php on line 67

Drupal 9.5.3
rector/rector 0.15.18
palantirnet/drupal-rector: 0.15.1
drupal/upgrade_rector: 1.0.0-alpha8

Yes, you are right – but 1 || 2 was downgrading my composer/installers from v2.2.0 => v2.0.0

So i changed it to "^1.0 || ^2.0"

(I hope that's right - I don't have a lot of experience with that kind of stuff ... at least it works for me ... :-)

Patch for my problem.

tfranz → created an issue.

You can do that with views:
Create a view: for fields, showing as block, showing book pages
Add a Relationship to "The book the node is in."
Add a title-field with relationship to the "The book the node is in." (<- Thats the trick!)

... and you have to add a context in order to show only the corresponding book title, if you have more than one book.

(Attached is my config-file for the view as a starting point – including the context-settings.)

I was wondering about the last sentence and if it was a bit harsh. But on the other hand it is true, because without further design it works technically, but is hardly usable. I think your notes are all right!

I'm fine with the improvements and Release notes – thank you! :-)

Just as a suggestion, a new patch with the following additional changes:

1. Rename the stylesheets to "oembed-lazyload" to make them easier to find in listings
2. Separation of the stylesheets into necessary and design, so that the design can be removed or overwritten more easily
3. And a few minor design enhancements - while we're at it ;)

Yes, that's a good point and i can understand it.

Instead of a submodule i would be happy enough, if all the nice stylings would be in a separate css-file.
So i can simply "switch it off" or override that file - if i want.

1. Which module(s) were you using? (oembed_lazyload_youtube or a customized one?)

I'm just using oembed_lazyload – not oembed_lazyload_youtube.

2. Can you paste in a configuration export of the module(s) settings?

I use it on the cores media-video-field:

langcode: de
status: true
dependencies:
config:
- field.field.media.external_video.field_media_oembed_video
- media.type.external_video
module:
- oembed_lazyload
id: media.external_video.default
targetEntityType: media
bundle: external_video
mode: default
content:
field_media_oembed_video:
type: lazyload_oembed
label: hidden
settings:
max_width: 1920
max_height: 1080
strategy: onclick
intersection_observer_margin: ''
third_party_settings: { }
weight: 1
region: content
hidden:
created: true
langcode: true
name: true
thumbnail: true
uid: true

Two more things:

Your patch works fine with Olivero 9.4.8., but with Bartik 9.4.8 i had to add some more styling to get it to work:

.oembed-lazyload__button {
    z-index: 0;
}

And: I like the new button styles!
But I usually prefer it when modules don't include "decorative" styles like font-weight and rounded corners, otherwise I have to override them again in my designs.
Although I find your implementation nicer, I would therefore do without it in my opinion.

This is enough to be usable from my point of view:

.oembed-lazyload__visible-label {
  padding: 1rem;
  background-color: buttonface;
}

I think it has something to do with ckeditor 4 not respecting HTML5 (DIV-Element inside a P-Element).
You can't even insert something like that:
<p>Hello <div>world</div>!</p>

Maybe it can be solved by changing the way the editor "tidies up" the source-code:
https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dtd.html

... but i couldn't find out how ... :-(

There is a discussion on SO about the same behaviour:
https://stackoverflow.com/questions/19825802/how-to-configure-ckeditor-t...

Tested it with the experimental module for ckeditor 5 and it didn't work either.