- Issue created by @tfranz
- ๐ฎ๐ณIndia vikas shishodia
Hi @tfranz
I am just creating a patch with your zip file.
- @vikas-shishodia opened merge request.
- ๐ฉ๐ชGermany tfranz
Thank you!
I think this should go into a new version (2.0.0 ?), because it is not backwards-compatible. - ๐ฎ๐ณIndia vikas shishodia
Hi @wengerk
Can you please create a new branch 8.x-2.x So that we can push the ckeditor5 compatible code against that branch for this module. - ๐ฉ๐ชGermany rgpublic Dรผsseldorf ๐ฉ๐ช ๐ช๐บ
What does "I think it is not backwards-compatible to the older versions of the shy-module" mean? After all, in the HTML code that's finally stored in the field it should be just a
­
entity, right? So if I open such a field with the new CKEditor5 then I can see/edit the shy's with the new module, right?BTW: Thanks from me as well for the module. +10 :-)
- ๐ฉ๐ชGermany tfranz
@rgpublic: Yes, i think you should be right, but i haven't tested it.
It should not break anything, but at least it could simply ignore the old modules template
<span class="shy">­</span>
. The new one is<shy>­</shy>
.
Or it could be that a new filter of CKEditor5 strips out the old tag and removes it completely. Then all old markups are lost.But it would be nice, if the new module could take care of the old script, too.
- ๐บ๐ฆUkraine i-trokhanenko Lutsk ๐บ๐ฆ
Created 2.x branch for the CKEditor 5 compatibility
-
i-trokhanenko โ
committed b00ce6d7 on 2.0.x authored by
vikas shishodia โ
Issue #3346570 by vikas shishodia, tfranz, i-trokhanenko, quotientix,...
-
i-trokhanenko โ
committed b00ce6d7 on 2.0.x authored by
vikas shishodia โ
- Status changed to Needs review
over 1 year ago 2:01pm 19 May 2023 - ๐บ๐ฆUkraine i-trokhanenko Lutsk ๐บ๐ฆ
Committed the MR#4 to the 2.0.x branch, please test
- ๐ฉ๐ชGermany tfranz
Thank you โ i tried the new branch and it seems to work for me (Drupal10.0.9).
I have some small changes:
1. I think we don't need the png-icons. As far as i can see, you can delete them including the folder "hidpi".
2. I removed the dependency todrupal:ckeditor
3. The translations couldn't be found, because the "interface translation server pattern
" inshy.info.yml
is wrong. It should be:
interface translation server pattern: modules/contrib/%project/translations/%language.po
4. And the translations are wrong. The "msgid" is "Replaces<shy></shy>
tag with non-breaking space."Another thing - the modules description:
Minimal module to insert a soft hyphen into the content by pressing Ctrl+Hyphen or using the provided button.
At least for me the keys "Ctrl+Hyphen" don't work. -
i-trokhanenko โ
committed b6b6a09d on 2.0.x authored by
tfranz โ
Issue #3346570 by vikas shishodia, tfranz, i-trokhanenko, quotientix,...
-
i-trokhanenko โ
committed b6b6a09d on 2.0.x authored by
tfranz โ
- Status changed to RTBC
over 1 year ago 2:00pm 26 May 2023 - Status changed to Fixed
over 1 year ago 2:05pm 26 May 2023 - ๐บ๐ฆUkraine i-trokhanenko Lutsk ๐บ๐ฆ
Created 2.0.0 โ version of the module CKEditor 5 compatible. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.