Prepare module for Drupal 10

Created on 4 March 2023, almost 2 years ago

Make this module ready for Drupal 10.

āœØ Feature request
Status

Active

Version

3.0

Component

Code

Created by

šŸ‡µšŸ‡­Philippines arpeggio

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @arpeggio
  • First commit to issue fork.
  • Status changed to Needs review about 1 year ago
  • šŸ‡®šŸ‡³India sarwan_verma

    Hi @arpeggio,
    I have have fixed this issue "Prepare module for Drupal 10" and also attached patch,
    please review and verify.

  • Status changed to Needs work about 1 year ago
  • šŸ‡ØšŸ‡­Switzerland ayalon

    The patch does not work because it does not fix the composer.json. Therefore an upgrade is not possiblle to Drupal 10 using composer.

  • Status changed to Needs review 10 months ago
  • šŸ‡®šŸ‡³India Hemant Bansal

    I have uploaded new patch please review.

  • Status changed to RTBC 8 months ago
  • šŸ‡®šŸ‡³India arunkumark Coimbatore

    Verified the patch #6. The patch was applied and working fine. Moving to RTBC.

  • šŸ‡®šŸ‡³India arunkumark Coimbatore

    Updated the Merge request to reflect changes in composer.json and Readme

  • šŸ‡ŗšŸ‡øUnited States shamilto2000

    This will not install correctly using Composer on Drupal 10, see the error results from trying to install 4.0@alpha. I note that when I follow the sourcecode link, the default package is set at 8.x, not 4.0.

    Your requirements could not be resolved to an installable set of packages.

    Problem 1
    - Root composer.json requires drupal/geotimezone ^4.0@alpha -> satisfiable by drupal/geotimezone[4.0.0-alpha1].
    - drupal/geotimezone 4.0.0-alpha1 requires drupal/core ^8.7.7 || ^9 -> found drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but these were not loaded, likely because it conflicts with another require.

  • šŸ‡©šŸ‡ŖGermany heikofischer

    @arpeggio could you merge the changes, we are stuck in an update process, geo time zone will not install, see #10.

  • Status changed to Needs review 27 days ago
  • šŸ‡©šŸ‡ŖGermany tfranz

    I had to lenient the module in the composer.json with the composer-plugin:
    https://github.com/mglaman/composer-drupal-lenient
    Then it worked ā€“ without the patch.

  • šŸ‡®šŸ‡³India arunkumark Coimbatore

    @tfranz As per your comment, No need for the patch while we are installing using the Composer?

    Or the latest version 4.0.0-alpha1 by default working fine. Please share your finding in details.

  • šŸ‡©šŸ‡ŖGermany tfranz

    The patch can`t be applied, because composer first checks the requirements before applying the patches which would fix them ā€¦
    I think the patch could work when updating from Drupal 9.x:
    Install geotimezone, apply the patch, update to Drupal 10.x.

    I am running Drupal Core 3.10.3.
    When installing geotimezone via Composer like composer require 'drupal/geotimezone:^4.0@alpha' i get the following error:

    Your requirements could not be resolved to an installable set of packages.
    drupal/geotimezone 4.0.0-alpha1 requires drupal/core ^8.7.7 || ^9 -> found drupal/core[8.7.7, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but the package is fixed to 10.3.10

    When i add drupal/geotimezone to my lenient-list ā€¦
    "drupal-lenient": {"allowed-list": ["drupal/geotimezone"]}
    ā€¦ i can install geotimezone:
    composer require 'drupal/geotimezone:^4.0@alpha'

    The patch (which doesn`t add any functional code) is not needed any more, because drupal-lenient overrides the "require": {"drupal/core": "^8.7.7 || ^9"}

    I couldn't find an error yet. But this is a workaround and should be fixed in the next version ā€¦

Production build 0.71.5 2024