- First commit to issue fork.
- π¦πΊAustralia nterbogt
I've redone the permission form configuration. Also moved it to a merge request.
I still need to implement the bundle configuration, but the rest is done, as far as I know.
- last update
about 1 year ago 34 pass - @nterbogt opened merge request.
- Status changed to Needs review
about 1 year ago 10:48pm 30 October 2023 - π¦πΊAustralia acbramley
Let's rebase this against 2.1.x.
I'm not sure what the 2.x branch was created for but it's effectively dead.
- Status changed to Needs work
about 1 year ago 2:35am 1 November 2023 - Status changed to Needs review
about 1 year ago 2:46am 1 November 2023 - last update
about 1 year ago 34 pass - Status changed to Needs work
about 1 year ago 2:53am 1 November 2023 - π¦πΊAustralia acbramley
There's some fairly complex logic in that form that needs tests. Also pushing some linting updates.
- π¦πΊAustralia nterbogt
I agree with the complex logic in the form, I'm also not really sure about a decent approach to test that. Do you have any recommendations?
A unit test that just checks the default values and possible options could work, but might not be what you're after.
- last update
about 1 year ago 34 pass - π¦πΊAustralia acbramley
@nterbogt a unit test isn't going to test the form. It should be a functional test that submits the form and checks the config after the fact.
- Status changed to Needs review
about 1 year ago 11:40am 8 November 2023 - π¦πΊAustralia nterbogt
Added a functional test for the settings form. Has a phpstan warning, but it's the same warning in a lot of other projects.
https://git.drupalcode.org/project/token/-/jobs/275660
The warning is documented here.
https://www.drupal.org/docs/develop/development-tools/phpstan/handling-u... β
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Left a couple of questions on the MR
-
acbramley β
committed bbedd516 on 2.1.x authored by
nterbogt β
Issue #3156692 by nterbogt, acbramley, arvind.kinja, larowlan: Provide...
-
acbramley β
committed bbedd516 on 2.1.x authored by
nterbogt β
- Status changed to Fixed
about 1 year ago 11:57pm 9 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
9 months ago 10:43am 28 March 2024 - π¬π§United Kingdom stephen-cox
Great to see an admin UI for this. Any chance of a new release including this?
The admin UI is useful for use as part of this issue https://github.com/localgovdrupal/localgov/issues/600. As an interim I've created a PR to use the dev branch (https://github.com/localgovdrupal/localgov/pull/691), but would be nice if we didn't have to reference specific commits in the dev branch.
- π¦πΊAustralia acbramley
@stephen-cox https://www.drupal.org/project/preview_link/releases/2.1.0-alpha3 β :) thanks for prompting!