- Issue created by @Anybody
- Status changed to Needs review
almost 2 years ago 8:22am 2 February 2023 - ๐ฎ๐ณIndia noorulshameera
Adding patch to fix Drupal 10 compatibility issues.
- ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Charchil Khandelwal
Patch #2 tested and successfully applied.
- ๐ฎ๐ณIndia yashingole
I have reviewed and checked Patch #2 this works for drupal 9.4 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.4 and the Flag page on 10 have been attached for reference: - First commit to issue fork.
- @grevil opened merge request.
- Status changed to RTBC
almost 2 years ago 1:41pm 6 February 2023 - ๐ฉ๐ชGermany Grevil
RTBC +1!
I created an MR containing the changes by @noorulshameera for an easier review and auto fixed the remaining phpcs errors.
- Status changed to Needs work
almost 2 years ago 10:22am 7 February 2023 - ๐ญ๐บHungary lonalore Budapest, Hungary
@noorulshameera and @grevil
The new Once library โ was introduced in Drupal v9.2, this means that the module will no longer be compatible with Drupal 8, so please set the minimum version to 9.2:
core_version_requirement: ^9.2 || ^10
Thank you!
- Status changed to Needs review
almost 2 years ago 7:50am 8 February 2023 - Status changed to RTBC
almost 2 years ago 2:20pm 8 February 2023 - ๐ญ๐บHungary lonalore Budapest, Hungary
Looks good to me! Thank you!
- ๐บ๐ธUnited States attheshow
Thanks for the merge request/patch. If anyone needs a patch file from #10 for composer installation, it's at:
https://git.drupalcode.org/project/flag_anon/-/merge_requests/3.patch -
noorulshameera โ
authored c69bc590 on 8.x-1.x
Issue #3338148 by Grevil, Charchil Khandelwal, noorulshameera,...
-
noorulshameera โ
authored c69bc590 on 8.x-1.x
- Status changed to Fixed
over 1 year ago 2:00pm 7 July 2023 - ๐ฉ๐ชGermany Anybody Porta Westfalica
Thank you all! I think @Grevil should also be credited for his fix and review.
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@noorulshameera, @Antonnavi are you planning to create a new release or should I?
Automatically closed - issue fixed for 2 weeks with no activity.