Adding the changes as a patch to be used.
@Shreya_th I have verified the MR looks good and fixes the issue. RTBC+1
@sarwan no need to update from core_version_requirement key ^8.8 || ^9 || ^10 to ^8 || ^9 || ^10. just need to remove the core key from modules/contrib/audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml. this will fix the issue.
The patch looks good and is applied cleanly and the module is now compatible with the D10 version. Attached the upgrade status module report post applying the patch for reference.
RTBC+1
If core key is removed then core_version_requirement key should be altered be to core_version_requirement: ^8.8 || ^9 as the 'core_version_requirement' key is not recognized before drupal version 8.7.7. Adding patch with the change.
The patch looks good and works well. Able to add translation text for the warning message. Attached a screenshot after adding warning message in French language.
RTBC+1.
noorulshameera → made their first commit to this issue’s fork.
The #3patch works fine and the text 'Phone number' in PhoneNumberWidget is now translatable. Attaching Screenshot after applying patch.
Steps to reproduce:
Apply the patch #3.
Enable the module.
Add "Phone number" field type in any content type.
under manage form display of the content type, able to see "Phone number" text in the widget settings.
once the translatable string is added, able to see the translated text.
RTBC+1
I have verified #3 patch working fine and applied cleanly. It resolves all the issues mentioned in the Drupal upgrade status module. Attached a screenshot of the upgrade status report before and after applying the patch.
One more question @Nels.
is it necessary to remove Drupal 8 version from 'core_version_requirement'?
else we can include in this way. Please confirm.
core_version_requirement: ^8.8 || ^9 || ^10
I reviewed the MR and found that 'core_version_requirement' should also be altered to core_version_requirement: ^8.8 || ^9.
-core: 8.x
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^8.8 || ^9
because the key 'core_version_requirement' was not recognized before the drupal 8.7.7 version.
Added a patch to fix this issue. Please review
Hi @sonal,
The changes in the .info.yml file look good and follow Drupal standards.
RTBC+1
Verified the patch works fine which replace the deprecated function urlInfo() with correct function as per drupal standard mentioned in
https://www.drupal.org/node/2614344 →
RTBC+1
I verified the patch works fine and we can remove 'jquery.once' from the libraries.yml file and no need to replace it with core/once, since it is not used in both datepicker.js and views-year-filter.js files in the codebase.
RTBC+1
Adding patch for fixing info.yml issue.
Hi @Raveen Thakur,
The patch looks good to update jQuery.once by core/once.
The changes you have made to the .info file should be altered.
-core: 8.x
-core_version_requirement: ^8 || ^9 || ^10^8 must be replaced with ^8.8 as per drupal standard ( https://www.drupal.org/node/3070687 → ).
I have verified that the patch was applied successfully and the deprecation message gets removed from the upgrade status report.
Verified that the patch works fine.
Steps to reproduce:
1. Install and enable the module
2. Edit a piece of content with Paragraphs
3. Un-check the "Published" button on one of your Paragraphs
4. Save and view the node
5. we should see a button that says "Toggle visibility of unpublished items" in the lower right corner of the page. but it is not visible due to jQuery once issue.
After applying the patch able to see the toggle visibility button.Added screenshot for before and after applying patch.
I will review this
I verified that patch #2 applied cleanly and it replaces all the occurrences of the deprecated function utf8_encode() in the code.
Able to reproduce the issue and the given patch works fine. After applying the patch, able to save the form without warnings.
The patch was applied successfully and replaced the typo error in all the necessary places in the code.
I reviewed that patch #6 applied successfully and works well as per Drupal standards. ( https://www.drupal.org/node/3070687 → ).
Verified that the patch#2 Applied clearly and able to see configure button in module listing page. Hence moving to RTBC
Adding a patch to make the module compatible with Drupal 10.
noorulshameera → created an issue.
Adding a patch to fix the issue.
noorulshameera → created an issue.
Adding patch to fix D10 compatibility issues.
Adding patch to fix the issue.
noorulshameera → created an issue.
Patch #2 applied cleanly.
However found one more issue while running
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/force_users_logout
FILE: /Applications/MAMP/htdocs/d9/web/modules/contrib/force_users_logout/force_users_logout.module
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
36 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
so adding a patch which fixes issues including above one as well.
Adding a patch to implement the hook_help() function.
noorulshameera → created an issue.
noorulshameera → made their first commit to this issue’s fork.
Adding a patch to implement hook_help() function.
noorulshameera → created an issue.
Adding a patch to fix the deprecation issue.
Adding a patch to fix the issues.
noorulshameera → created an issue.
Adding a patch to fix the issue.
noorulshameera → created an issue.
Adding patch to fix the issue.
noorulshameera → created an issue.
Adding patch to fix the issue.
noorulshameera → created an issue.
Adding a patch to remove unused use statements in .module file.
noorulshameera → created an issue.
Adding a patch to fix coding standard issues.
noorulshameera → created an issue.
Adding a patch to fix the issue.
noorulshameera → created an issue.
Adding a patch to remove PathProcessor class file.
Adding a patch to fix the issue.
noorulshameera → created an issue.
Adding patch to fix PHPCS issues.
noorulshameera → created an issue.
Adding patch to implement hook_help().
noorulshameera → created an issue.
Adding patch to fix Drupal 10 compatibility issues.
Adding a patch to implement hook_help().
noorulshameera → created an issue.
Adding a patch to fix the issue.
noorulshameera → created an issue.
Adding patch to fix PHPCS issues.
noorulshameera → created an issue.
Adding patch to fix Drupal 10 compatibility issues.
Created a patch to remove the License.txt file.
noorulshameera → created an issue.
Adding a patch to fix phpcs issue.
noorulshameera → created an issue.
Adding patch to fix PHPCS issue.
noorulshameera → created an issue.
Adding a patch to fix the deprecation issue.
Adding patch that fixes drupal 10 compatibility issues.
noorulshameera → created an issue.
Adding patch that fixes drupal 10 compatibility issues.
noorulshameera → created an issue.
Adding patch that fixes drupal 10 compatibility issues.
Created a patch to fix the issue. Please review.
noorulshameera → created an issue.
Adding patch to implement hook_help() function.
noorulshameera → created an issue.
Adding patch to implement hook_help() function.
noorulshameera → created an issue.
Adding patch to implement hook_help() function.
noorulshameera → created an issue.
Adding patch to implement hook_help() function.
noorulshameera → created an issue.
Adding patch to remove License.txt file.
noorulshameera → created an issue.
updated core_version_requirement in info.yml file.
noorulshameera → created an issue. See original summary → .
updated core_version_requirement in info.yml file.
noorulshameera → created an issue. See original summary → .
Adding patch with D10 compatibility issues fixed.
Adding patch with D10 compatibility issue fixed.
Adding patch with D10 compatibility issues fixed.
Adding patch with D10 compatibility issue fixed.