Drupal 10 Compatibility

Created on 24 May 2023, over 1 year ago
Updated 7 January 2024, 11 months ago

Problem/Motivation

Module is not compatible with D10

Steps to reproduce

* Run upgrade status report:

- Value of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.

- Call to deprecated function module_load_include(). Deprecated in drupal:9.4.0 and is removed from drupal:11.0.0. Use Drupal::moduleHandler()->loadInclude($module, $type, $name = NULL). Note that including code from uninstalled extensions is no longer supported.

Proposed resolution

* updated .info.yml file and change the deprecated function with D10 compatibility.

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Fixed

Version

1.1

Component

Code

Created by

🇨🇴Colombia jabonillac@gmail.com

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jabonillac@gmail.com
  • First commit to issue fork.
  • Merge request !1Issue#3362287: D10 readiness. → (Merged) created by sakthi_dev
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India sakthi_dev

    Please review.

  • Status changed to Needs work about 1 year ago
  • 🇮🇳India anand.toshniwal93

    After applying above patch am still getting an below error

    Error : Call to undefined function _template_preprocess_webform_composite() in template_preprocess_webform_hierarchy() (line 28 of /app/docroot/modules/contrib/webform_hierarchy/webform_hierarchy.module )
    #0 [internal function]: template_preprocess_webform_hierarchy(Array, 'webform_hierarc...', Array)
    #1 /app/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(287): call_user_func_array('template_prepro...', Array)
    #2 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(433): Drupal\Core\Theme\ThemeManager->render('webform_hierarc...', Array)
    #3 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(204): Drupal\Core\Render\Renderer->doRender(Array, true)
    #4 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(148): Drupal\Core\Render\Renderer->render(Array, true)
    #5 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(580): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
    #6 /app/docroot/core/lib/Drupal/Core/Render/Renderer.php(149): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure) )
    #7 /app/docroot/core/lib/Drupal/Core/Render/MainContent/AjaxRenderer.php(66): Drupal\Core\Render\Renderer->renderRoot(Array)
    #8 /app/docroot/core/lib/Drupal/Core/Form/FormAjaxResponseBuilder.php(89): Drupal\Core\Render\MainContent\AjaxRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
    #9 /app/docroot/core/lib/Drupal/Core/Form/EventSubscriber/FormAjaxSubscriber.php(109): Drupal\Core\Form\FormAjaxResponseBuilder->buildResponse(Object(Symfony\Component\HttpFoundation\Request), Array, Object(Drupal\Core\Form\FormState), Array)
    #10 [internal function]: Drupal\Core\Form\EventSubscriber\FormAjaxSubscriber->onException(Object(Symfony\Component\HttpKernel\Event\ExceptionEvent), 'kernel.exceptio...', Object(Drupal\Component\EventDispatcher\ ContainerAwareEventDispatcher))

    I was able to get this working by replacing this
    \Drupal::moduleHandler()->loadInclude('inc', 'webform', 'includes/webform.theme.template');

    with \Drupal::service('module_handler')->loadInclude('webform', 'inc', 'includes/webform.theme.template');

  • Status changed to Needs review about 1 year ago
  • First commit to issue fork.
  • 🇮🇳India vakulrai

    Attaching the patch for visibility:

  • Status changed to Needs work about 1 year ago
  • 🇮🇳India Bushra Shaikh

    I applied patch #9 got below error:

    error: patch failed: webform_hierarchy.info.yml:2
    error: webform_hierarchy.info.yml: patch does not apply
    error: patch failed: webform_hierarchy.module:24
    error: webform_hierarchy.module: patch does not apply
    
  • Status changed to Fixed 11 months ago
  • 🇷🇺Russia maximpodorov

    Committed. Thank you.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024