- Issue created by @noorulshameera
- Status changed to Needs review
almost 2 years ago 7:47am 1 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
Charchil Khandelwal โ made their first commit to this issueโs fork.
- Assigned to Charchil Khandelwal
- Status changed to Needs work
almost 2 years ago 9:27am 2 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
FILE: ...y_google_analytics_counter\easy_google_analytics_counter.api.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
7 | WARNING | @author tags are not usually used in Drupal, because
| | over time multiple contributors will touch the code
| | anyway
31 | WARNING | Unused variable $nid.
----------------------------------------------------------------------FILE: ...\modules\easy_google_analytics_counter\src\ConnectionService.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
9 | WARNING | There must be no blank line following an inline
| | comment
14 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
173 | WARNING | Unused variable $reportIndex.
----------------------------------------------------------------------FILE: ...easy_google_analytics_counter\src\ConnectionServiceInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
7 | WARNING | The class short comment should describe what the class
| | does and not simply repeat the class name
----------------------------------------------------------------------FILE: ...pal\modules\easy_google_analytics_counter\src\Form\AdminForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the
| | class does and not simply repeat the class name
----------------------------------------------------------------------Need to fix these warnings.
- @charchil-khandelwal opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 9:35am 2 February 2023 - ๐ฎ๐ณIndia Charchil Khandelwal
All warnings are fixed now.
Created MR for this issue.
Please review. - Assigned to himanshu_jhaloya
- Issue was unassigned.
- Status changed to RTBC
almost 2 years ago 5:30am 7 February 2023 - ๐ฎ๐ณIndia himanshu_jhaloya Indore
Hi @charchil-khandelwal Reviewed the MR!3 look good checked the phpcs issues no Error & warning was found. Moving to RTBC
-
Charchil Khandelwal โ
committed e93956fb on 2.0.x
Issue #3338152: Fix coding standard issue | PHPCS
-
Charchil Khandelwal โ
committed e93956fb on 2.0.x
- Status changed to Fixed
almost 2 years ago 4:02pm 10 February 2023