Fix coding standard | PHPCS

Adding a patch to fix coding standard issues.

There is still a phpcs issue pending to be addressed. Please see the attachment.

I can work on this and creating the MR.

Created MR with all phpcs issues fixed.

Hi @ hardikpandya

I reviewed MR!3 and verified it fixes all the errors reported by phpcs. Drupal core version 9.5.8, Telephone Validation 8.x-2.x-dev.

I added screenshots for reference.
Thank You.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.

Issue summary updated.

Hi @noorulshameera,

I have reviewed the changes and confirmed that Patch #12 was applied cleanly to the Telephone Validation module against 8.x-2.x-dev on Drupal 10.

And all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js telephone_validation

Please see the attached files for reference.

I'm moving this now to 'RTBC'.

Thank you!

To leverage Gitlab CI I need an up-to-date MR that will make sure tests are green before this is merged in.

Working on it.

Hi @zaporylie,
I tried applying the patch, but I encountered errors during the process. Additionally, I noticed that most of the changes indicated by the patch have already been fixed.
I'm attaching screenshots for your reference.

Co-incidentally working on CI, linting and static analysis for SMS Framework. And I watch this queue. So jumping in for a moment since these are easy fixes.

You might be interested in updating to a tougher PHPStan config, or using https://github.com/previousnext/coding-standard, in another issue.

New MR, doesnt use any prior patches or MR.

Thanks @dpi for this. I see you also uncovered a bug with dependency injection for the config form. I added 📌 The settings form is missing test coverage Active to add a test coverage for future-proofing this part. Also changed how dependency injection is handled in your MR and going to merge it now.

Merged. Thanks everyone involved.

Automatically closed - issue fixed for 2 weeks with no activity.