Remove the "core" key from the audio_embed_media.info.yml file

Shreya_th → made their first commit to this issue’s fork.

i have fixed this issue Remove the "core" key from the audio_embed_media.info.yml file, created patch and shared screenshot as well.

@Shreya_th I have verified the MR looks good and fixes the issue. RTBC+1

@sarwan no need to update from core_version_requirement key ^8.8 || ^9 || ^10 to ^8 || ^9 || ^10. just need to remove the core key from modules/contrib/audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml. this will fix the issue.

@noorulshameera thanks for quick response.

Hi Shreya_th

I reproduced the error and tested your patch, confirmed it removes the error and can enable the module, but the best approach was the MR but the MR failed to apply in my local. Please look at the screenshot I attached for your reference

Thank you

@kenyoOwen sorry from my side . i made changes in verion 8.x-2.x . I am working on this and will make changes in latest version.

Hi @kenyoOwen , Can you tell whether you have cloned it or installed it from composer and what are the configuration?

@kenyoOwen please apply this patch https://git.drupalcode.org/project/audio_embed_field/-/merge_requests/8/... and check.

MR looks good.

@sarwan the core_version_requirment key will not work in version < 8.7
Check here:- https://www.drupal.org/node/3070687 →

-core_version_requirement: ^8.8 || ^9 || ^10
+core_version_requirement: ^8 || ^9 || ^10

The existing line is correct; the changed line is not, as it would imply the module can be installed on any Drupal 8 release, while Drupal 8.7.7 and previous releases would throw an error because they do not recognize the core_version_requirement key.

Shreya_th → closed merge request !9

Hi @apaderno ,
Do I have to make changes this:
- core_version_requirement: ^8.8 || ^9 || ^10
+ core_version_requirement: ^8 || ^9 || ^10
in info.yml file.
Please confirm. Thank you

Hi @shreya_th, I agree with @apaderno you have to remove that and add ^8.8 in place of ^8.

Please remove that and raise pr.

Shreya_th → reopened merge request !9

Hi @apaderno ,
I had made changes according to your requirement i.e. -
- core_version_requirement: ^8.8 || ^9 || ^10
+ core_version_requirement: ^8 || ^9 || ^10 and
created MR for this. Kindly review the changes.

Thank you.

I can confirm patch on #5 works fine.

The .info.yml file is already not using the core value.

name: Audio Embed Field
type: module
description: 'Provides a field type for displaying audio from 3rd party providers such as Soundcloud.'
package: Audio
configure: audio_embed_field.admin_settings_form
core_version_requirement: ^8.8 || ^9 || ^10
dependencies:
  - drupal:field
  - drupal:image

Therefore, there is nothing more that needs to be fixed.

The core entry is not in the main module but is inside the submodule audio_embed_media. That's why this patch is needed.

@cesarmiquel I got it. Then MR 9 is totally wrong.

apaderno → changed the visibility of the branch 3385128-2 to hidden.

apaderno → changed the visibility of the branch 3385128-1 to hidden.

The core_version_requirement: ^8.8 || ^9 || ^10 line is correct. It cannot be changed to core_version_requirement: ^8 || ^9 || ^10 because previous Drupal 8 versions cannot handle a core_version_requirement line.