Please take this over... I have moved away from Drupal
Sorry for the delay
quietone → credited martin107 → .
The source code is public for you to use...
But at this point it that would be malpractice ...migration warnings started to be issued in 2006 as far as I remember.
There will be no ongoing support.
New release 3.1.0, please let me know.. If I have done something, unconventional
Thank you all
smustgrave → credited martin107 → .
martin107 → created an issue.
I think the first step here is to migrate this project to Drupal10
Trying to maintain a Drupal7 project at this point is malpractice.
I did not fix the errors ...yet.
a) Fixed up some errors I introduced from 276
b) Added, fixed up a few @throws tags.
Sorry for causing a mess.
I do not know what is wrong with the patch
After playing with this some more .. it because every
in 271 mariacha1 pointed out
Current problem seems to be that my recieved hash never matches my generated hash, so the files are never created.
in short for every test, the css and the js is 404'ing and so an avalanche of errors... my mistake
I am just posting one of our new url
/sites/default/files/css/css_0_eea631ea3cbc9e1a1c33518177e18dda52ac5f633ac13e55b48606de60fed335.css?theme=bartik&include=core/normalize%2Csystem/base%2Ccontextual/drupal.contextual-links%2Cquickedit/quickedit%2Cviews/views.module%2Ctoolbar/toolbar%2Ctour/tour-styling%2Ccontextual/drupal.contextual-toolbar%2Cuser/drupal.user.icons%2Cshortcut/drupal.shortcut%2Cbartik/global-styling%2Cclassy/base%2Cclassy/messages
While I think about the fix.
I am posting some minor changes here ... and deliberately not triggering the testbot.
A) I have fixup approx 35 coding standard errors.
B) For both CssCollectionOptimizerLazy.php and JsCollectionOptimizerLazy.php I am directory injecting the config_factory and dropping calls to \Drupal::config()
A) file_scan_directory is deprecated. and is triggering errors.
https://www.drupal.org/node/3038437 →
B) New cases of array() converted to []. as per coding standard
Reroll... no conflicts just auto-merging.
we MUST no longer be modifying *.js files directly
We modify *.es6.js and then transpile as described here :-
https://www.drupal.org/node/2815083 →
as a ultra trivial point new code in ModulesListForm uses array() when [] is preferred.
Minor coding standard fixes.
1)
Indirect modification of overloaded element of Drupal\Core\Field\FieldItemList
That is fixed by using
$node->setTItle()
instead of
$node->title[0]->value
NodeAdminTest now passes.
2) If we are swapping out "Engilsh title" we should replace it with "Spanish title"