Fix remaining VariableComment.MissingVar annotation

Implementing sniffs are not bugs, they are tasks.

The failing test is not related to these changes, I am retesting.

Changing the scope to make the change set smaller and easier to review.

Reviewed the updates and changes appear correct.

MR has merge conflicts.

quietone → closed merge request !535

quietone → changed the visibility of the branch 2924782-missing-var-annotation to hidden.

Rebased

Rebase seems good.

Rebased and changed the instance in \Drupal\FunctionalTests\Update\UpdatePathTestBase to an {@inheritdoc}.

MR has a merge conflict and a question about the change to phpcs.xml.dist.

Also, the release note snippet in the IS seems wrong, as we are enabling that in the parent issue - not here.

Rebased and had to fix mistakes so setting to NR.

Rebase seems good.

I think we should be changing phpcs.xml to enable the rule no? Also I think removing the @var when there is a default value is really odd.

@alexpott, thanks for the review.

Unfortunately, the scoping on this is unusual and the sniff can't be modified to cover this set of changes. However, I did enable the sniff for some file patterns. In the parent issue the remaining 50 errors in 32 files can be fixed and the sniff enable for all files.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

A straightforward rebase so restoring RTBC

This change confuses me because it's removing @var from stuff... also if I only apply the changes to the phpcs.xml.dist and run PHPCS the other error that's found is:

> phpcs --standard=core/phpcs.xml.dist --parallel="$( (nproc || sysctl -n hw.logicalcpu || echo 4) 2>/dev/null)" -- 'core'

FILE: /Volumes/dev/drupal/core/modules/block/tests/src/Kernel/NewDefaultThemeBlocksTest.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 37 | ERROR | Missing @var tag in member variable comment
-------------------------------------------------------------------------------------------

Time: 26.72 secs; Memory: 12MB

So the rule changes are not covering the changes being made here.

quietone → credited andriyun → .

quietone → credited martin107 → .

quietone → credited shkiper → .

quietone → credited xjm → .

The 'Overview' in the MR does not reflect the actual changes and it quite confusing. There were also truly unexpected errors on my part that I can't quite figure out how they happened. So, I started over and it turns out that this can now enable the sniff as well.

So, I am closing the parent as a duplicate, changing the title and moving credit.

All the documentation changes look good to me.
The remark of @alexpott has been addressed.
For me it is RTBC.

Couple of minor issues in the MR, also needs a reroll

Thanks for working on this.