- Issue created by @v.dovhaliuk
- 🇺🇦Ukraine v.dovhaliuk
The patch for the
<strong>FormElementHelper</strong>
has been provided. - Status changed to Needs review
over 1 year ago 9:03am 11 April 2023 - Status changed to Needs work
over 1 year ago 6:24pm 11 April 2023 - 🇺🇸United States smustgrave
Thanks for providing steps. Have not a full change to verify but this seems like a larger issue could be at work.
But as a bug will need a test case.
- 🇺🇸United States SocialNicheGuru
the numbering on the patch is wrong. but it fixed the problem for me.
- 🇮🇳India arpitk
- 🇺🇸United States pbabin
Ran into an issue today that triggered this for us in Drupal 10. Patch from #6 fixed the issue.
- First commit to issue fork.
- 🇮🇳India kalpanajaiswal
Created a MR from patch #6
MR: https://git.drupalcode.org/project/drupal/-/merge_requests/8297
Branch: 3353388-type-error-implode - 🇪🇸Spain dimaro Seville, Spain
I have reached this issue after having the same error using Inline Entity Form. The error appeared when developing a custom validation via "#element_validate", specifically when I called the setError method. I mention it in case it would be interesting that the test also covered this case. The path #6 fixes the issue.
- 🇯🇵Japan ultrabob Japan
I ran into this issue on an Open Social site, where a flexible group creation form had a taxonomy term entity reference field. Without the patch, there was no $form[$key]['#parent'] which led to a WSOD. The patch here showed the error message in the wrong place instead of the entire form white screening.
Confirming that patch #6 fixes the issue, but do not have time at the moment to contribute a test case to support the fix.
- First commit to issue fork.
- 🇮🇳India arunkumark Coimbatore
As per Comment #4, I have created the Test case for the patch. Verified the patch changes, Seems require manual test for change. The code changed for
FormElementHelper.php
, the class used in all form. The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3353388-type-error-implode to hidden.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3353388-typeerror-implode-argument to hidden.
- 🇺🇸United States smustgrave
Mr shouldn’t be against 11.0
The previous MR was pointing to the correct branch why open a new one?
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3353388-type-error-implode to active.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3353388-type-error-implode-fix to hidden.
- 🇮🇳India arunkumark Coimbatore
arunkumark → changed the visibility of the branch 3353388-type-error-implode-d11 to hidden.
- 🇮🇳India arunkumark Coimbatore
I faced the issue of creating MR against the 11.x branch. Now it is working to update the MR
- 🇺🇸United States smustgrave
Removing tests tag as https://git.drupalcode.org/issue/drupal-3353388/-/jobs/3078752 shows coverage.
believe rest of the feedback has been addressed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
How are we getting form elements with no parents. I think it points to unprocessed part of the form being added at the wrong point (after ) and to a larger issue.
Note I've followed the instructions in the error is no longer reproducible for a media field so I think we fixed this in a different, probably better, way.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I've tried to re-create the problem on 11.x, 10.1.0 and 10.0.0 following the steps in the issue summary and it did not work. Also this is very similar to 🐛 Notice: Undefined index: #parents in a Form/FormElementHelper.php Needs work