Seville, Spain
Account created on 5 November 2013, over 11 years ago
  • Senior Drupal Developer at YmbraΒ 
  • Member at AEDΒ  …
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain
πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain
πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

dimaro β†’ created an issue.

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

+1

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

Hey! I'm writing this comment after reading that one of the remaining tasks is to get feedback from the community. I find this feature quite useful. In fact, in one of the projects I'm working on, there is a need to increase the maximum number of items in an exposed filter that contains many countries. I believe that the functionality provided here provides both increasing that limit in the views you want, as well as making future filters that exceed that limit in other views automatically have the autocomplete widget.

Example for unlimited items: 3481590-unlimited_items.png
Example with the limit set to 100 items: 3481590-limit-set-to-100-items.png

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

+1

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

+1

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

I have reached this issue after having the same error using Inline Entity Form. The error appeared when developing a custom validation via "#element_validate", specifically when I called the setError method. I mention it in case it would be interesting that the test also covered this case. The path #6 fixes the issue.

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

Hey @itamair,

I have recently been checking the issue queue for this module due to everything that happened with the polyfill.io library (thanks for your quick intervention) and I saw this issue on RTBC for over 3 years. Is there any reason why this task was not merged at the time? In fact, I have seen that the patch was developed for the 2.x branch and now we are on the 3.x branch. So, I have created a new patch that applies to the current development branch since both semicolons continue in the code base.

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

Heey @cspitzlay,

Yes, right now I'm using Unzer OnSite, but I'm planning to use the Hosted Payment Page provided by Unzer. I don't think I can answer your question because I haven't checked how Unzer OffSite works yet, so right now I have no idea how an item is displayed there, but I'm still happy to contribute with this task and any other that improves the code base. This module and how the integration with Unzer is written is something that I continue to discover thanks to the fact that we used it on one of the projects.

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

Hey @cspitzlay,

In your opinion, does this warrant a new alpha release or is it enough that it is fixed in the dev version?

I would say not yet, I'm upgrading to address 2.x and I would like to create a new issue to include some of the new properties that address 2.x incorporates. Perhaps when that is resolved a new alpha release could be created.

Just out of interest: You mentioned that you have donations. Is there anything different from a regular order that has products with respect to the Unzer payment?

If I understand your question correctly, I would say that there is nothing different in terms of the amount donated. However, I do have a local patch in which it includes the Card holder property, something the module does not currently do.

πŸ‡ͺπŸ‡ΈSpain dimaro Seville, Spain

Hello @cspitzlay, taking into account that the Merge request was closed 3 months ago, it could be said that this issue is already solved and therefore this should be marked as "Fixed", right? os is there something else undone? Thanks!

Production build 0.71.5 2024