- Issue created by @gruberroland
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- Status changed to Needs work
9 months ago 9:43am 17 October 2023 - ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
The changes to line 57 of js/commerce_unzer.form.js seem wrong. Do they work for you?
- ๐ฎ๐ณIndia sarwan
Hi, sorry for my mistake. I raised the PR without checking. But now I have fixed this mistake.
Please review this new MR.
- ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
The patch updates the PHP version requirement to >= 8.1 although the Unzerdev SDK still supports 7.4.
Since Drupal 9 is no longer supported now ( https://www.drupal.org/docs/understanding-drupal/drupal-9-release-date-a... โ ) and Drupal 10 requires at least PHP 8.1 ( https://www.drupal.org/docs/getting-started/system-requirements/php-requ... โ ) I think we can accept that.
- ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
Here's the change record for the JavaScript change: https://www.drupal.org/node/3158256 โ
-
cspitzlay โ
committed 7255f762 on 1.0.x
Issue #3394485 by sarwan_verma: Remove dependency on jQuery once (D10...
-
cspitzlay โ
committed 7255f762 on 1.0.x
- ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
@gruberroland : I committed the patch that removes the dependency on jQuery once.
- Are you aware of any remaining issues with respect to D10 compatibility?
Other than packaging a release, I mean. - Are you using the onsite payment gateway? That part is known to have worked at least at some point but we do not use it in our project so it sees little testing.
- Are you aware of any remaining issues with respect to D10 compatibility?
- Status changed to Postponed: needs info
7 months ago 3:49pm 21 November 2023 - ๐ฉ๐ชGermany gruberroland
I can confirm that the current DEV version works with Drupal 10.1.6 with offsite payment gateway.
The onsite gateway seems to work, too. My test order was successful. But I do not use this in production as it does not support e.g. SEPA direct debit. - Status changed to Active
7 months ago 11:36am 24 November 2023 - ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
I created an issue some days ago about code quality improvements and modernization:
https://www.drupal.org/project/commerce_unzer/issues/3403407 ๐ Bring code up to snuff FixedI made the changes I had in mind and will soon create a new alpha release.
- Status changed to Needs review
4 days ago 11:29am 24 June 2024 - ๐ช๐ธSpain dimaro
Hello @cspitzlay, taking into account that the Merge request was closed 3 months ago, it could be said that this issue is already solved and therefore this should be marked as "Fixed", right? os is there something else undone? Thanks!
- Status changed to Fixed
4 days ago 3:16pm 24 June 2024 - ๐ฉ๐ชGermany cspitzlay ๐ฉ๐ช๐ช๐บ
Well, we are still at an alpha version and not a regular release.
But then again: D11 is near so keeping this open may not make much sense.