- Issue created by @dimaro
- Issue was unassigned.
- Status changed to Needs review
6 months ago 12:46pm 25 June 2024 - 🇮🇳India abhishek_virasat
abhishek_gupta1 → made their first commit to this issue’s fork.
- Status changed to RTBC
6 months ago 11:37am 26 June 2024 - 🇮🇳India abhishek_virasat
@dimaro, I have tested your Patch locally following mentioned step to reproduce. Issue has Fixed now, its working well for me. Also I created MR easy to merge. moving RTBC++
-
cspitzlay →
committed 3035d1b9 on 1.0.x authored by
abhishek_gupta1 →
Issue #3457004 by abhishek_gupta1, dimaro: Undefined array key "...
-
cspitzlay →
committed 3035d1b9 on 1.0.x authored by
abhishek_gupta1 →
- Status changed to Fixed
6 months ago 12:24pm 26 June 2024 - 🇩🇪Germany cspitzlay 🇩🇪🇪🇺
Looks good. Thanks to both of you.
@dimaro
- In your opinion, does this warrant a new alpha release or is it enough that it is fixed in the dev version?
- Just out of interest: You mentioned that you have donations. Is there anything different from a regular order that has products with respect to the Unzer payment?
- 🇪🇸Spain dimaro Seville, Spain
Hey @cspitzlay,
In your opinion, does this warrant a new alpha release or is it enough that it is fixed in the dev version?
I would say not yet, I'm upgrading to address 2.x and I would like to create a new issue to include some of the new properties that address 2.x incorporates. Perhaps when that is resolved a new alpha release could be created.
Just out of interest: You mentioned that you have donations. Is there anything different from a regular order that has products with respect to the Unzer payment?
If I understand your question correctly, I would say that there is nothing different in terms of the amount donated. However, I do have a local patch in which it includes the Card holder property, something the module does not currently do.
- 🇩🇪Germany cspitzlay 🇩🇪🇪🇺
Ah, you are using the on-site gateway, don't you?
I was wondering what a donation checkout looked like on the offsite paypage.
For example, if you needed to add a custom donation item to the cart so it all adds up in the cart display on that external page. - 🇪🇸Spain dimaro Seville, Spain
Heey @cspitzlay,
Yes, right now I'm using Unzer OnSite, but I'm planning to use the Hosted Payment Page provided by Unzer. I don't think I can answer your question because I haven't checked how Unzer OffSite works yet, so right now I have no idea how an item is displayed there, but I'm still happy to contribute with this task and any other that improves the code base. This module and how the integration with Unzer is written is something that I continue to discover thanks to the fact that we used it on one of the projects.
Automatically closed - issue fixed for 2 weeks with no activity.