- Issue created by @arti_parmar
- Status changed to Needs work
about 1 year ago 11:42am 3 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since PHP_CodeSniffer is used, the issue summary should show the complete report given by
phpcs
, not part of it. - Issue was unassigned.
- 🇮🇳India arpitk
Hi I have created a patch with some fixes. Few more issues need to be worked on. Please review.
remaining issues
FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/feeds_ldap.install
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Fetcher/Form/QueryFetcherFeedForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Fetcher/QueryFetcher.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Result/QueryFetcherResult.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Expected "" but found "???" for @var tag in member variable comment
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/feeds_ldap.info.yml
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------
Thanks! - Status changed to Needs review
about 1 year ago 10:40pm 7 June 2023 - Assigned to arti_parmar
- Issue was unassigned.