Fix issues reported by phpcs.

Created on 13 June 2023, over 1 year ago
Updated 16 June 2023, over 1 year ago

Problem/Motivation

Warnings reported by phpcs sniffer.

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/acquia_cms_site_studio/README.md
---------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------
17 | WARNING | Line exceeds 80 characters; contains 177 characters
19 | WARNING | Line exceeds 80 characters; contains 233 characters
---------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/acquia_cms_site_studio/acquia_cms_site_studio.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
11 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
12 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
13 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
14 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
15 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
19 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig .

Proposed resolution

Work on a patch and get it reviewed.

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India arpitk

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @arpitk
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India arpitk

    Please review the patch.

    Thanks!

  • Status changed to RTBC over 1 year ago
  • 🇵🇭Philippines paraderojether

    Hi @arpitk

    I reviewed patch 2, I applied it against Acquia CMS Site Studio 1.x-dev, and confirmed it fixes the issues reported by phpcs.

    I added screenshots for reference.
    Thank You.

Production build 0.71.5 2024