Fix the issues reported by phpcs

Open on Drupal.org →

Created on 8 June 2023, over 1 year ago

Updated 12 June 2023, over 1 year ago

Problem/Motivation

FILE: /var/www/html/vb/d_cont/file_sync/file_sync.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
24 | WARNING | Line exceeds 80 characters; contains 85 characters
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/Event/OperationEventsInterface.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/Event/BatchEventBase.php
------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------
22 | ERROR | [ ] Missing parameter name
33 | ERROR | [x] Return comment indentation must be 3 spaces, found 2 spaces
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/Form/FTPBatchForm.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
34 | ERROR | [ ] Missing member variable doc comment
36 | ERROR | [ ] Missing member variable doc comment
119 | ERROR | [x] Missing function doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/Form/OperationForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
176 | ERROR | [x] Case breaking statements must be followed by a single blank
| | line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/OperationPluginManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
29 | ERROR | [x] Perl-style comments are not allowed; use "// Comment" instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/BatchInterface.php
------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------
25 | ERROR | [x] Expected "int" but found "integer" for parameter type
27 | ERROR | [x] Expected "int" but found "integer" for parameter type
34 | ERROR | [ ] Type hint "array" missing for $context
------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/FTPClient.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
190 | ERROR | [x] Expected newline after closing brace
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...var/www/html/vb/d_cont/file_sync/src/Plugin/file_sync/FTPDirectorySync.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
13 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/src/Plugin/OperationPluginBase.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
23 | ERROR | [ ] Parameter $logger is not described in comment
85 | ERROR | [x] Expected 1 blank line after function; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/file_sync/file_sync.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 269ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig file_sync/

Proposed resolution

Fix all the issues for Drupal and DrupalPractice coding standards

Remaining tasks

Patch review.

📌 Task

Status

Needs review

Component

Code

Created by

🇮🇳India urvashi_vora Madhya Pradesh, India

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Issue created by @urvashi_vora
Status changed to Needs work over 1 year ago5:22am 9 June 2023

Comment over 1 year ago →

🇵🇭Philippines paraderojether

Hi reviewed coding-standard-fixes.patch, and there are still remaining warnings shown below:

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/file_sync/file_sync.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

Time: 527ms; Memory: 12MB

Please check.
Thank You.

First commit to issue fork.
@shivam_tiwari opened merge request.
Status changed to Needs review over 1 year ago6:24am 9 June 2023
Comment over 1 year ago →
🇮🇳India shivam_tiwari
Assigned to arpitk
Comment over 1 year ago →
🇮🇳India arpitk
Reviewing the MR.
Issue was unassigned.
Comment over 1 year ago →
🇮🇳India arpitk
Please review MR.

Thanks!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024