TypeError: must be RequestStack, EntityTypeManager given

Yes, I think the most recent version of Drupal Commerce broke things for this module.

Patches welcome ❤️

Hi @eiriksm, I have worked on a patch for the fix. Please review.

Thanks!

That's great and probably works perfectly! And feel free to use this, whoever needs a patch.

However, this will only work on commerce 2.36. And will crash on 2.35.

So what I would love to see:

- a patch that works for both (or all) versions
- the change done in a merge request please 😬❤️✌️

I also re enabled tests now (outdated config) so let's get green tests in 2 separate MRs, where one is adding a constraint on commerce to use < 2.36 and the other is not 🚀

I created a patch that makes the CommerceAjaxCartMessageSubscriber compatible with commerce version 2.36 and lower.
MR is also created. Please review

Just to make sure it works on 2.35 as well

eiriksm → closed merge request !2

Fixed coding stardards

The last submitted patch, 11: 3366808-11-typeerror-must-be.patch, failed testing. View results →

Awesome 👍

Can you also fix the unit tests? It's simply the case of mocking the new param and using the setter there?

Thanks for that, but that does not work 🤓

Referring to the post in #14, which does not fix the unit test and has coding standard violations

Attempt to fix the Unit tests.

Sorry for the #17, there was a misclick..
Here's the correct file uploaded

Fixed the small coding standards issue.

Let's get this shipped

Automatically closed - issue fixed for 2 weeks with no activity.