ImageStyle::load calls should be avoided in classes, use dependency injection instead

Kindly review patch.

Reviewing this.

Hi the patch #2 applies cleanly and the error mentioned in the issue description is fixed. However the issue summary need to be updated with the command and the arguments used to check should be mentioned in the summary. Moving it to Needs Works.

Thanks!

Hi I have added command with arguments required for this issue in issue summary.
Please have a look.

Used command with arguments is:-
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/custom/colorbox

Hi arti_parmar

I applied patch #2 → and confirmed that it fixed the phpcs issues mentioned in description, but it added a 1 warning which is:

FILE: /Users/studenttrainees/Project10/drupalorg10/docroot/modules/contrib/colorbox/src/Plugin/Field/FieldFormatter/ColorboxFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 930ms; Memory: 14MB

Please see the screenshots attached.

Thank you.

Patch updated.
Please review.

The last submitted patch, 8: 3366368-8.patch, failed testing. View results →

The Patch "3366368-11" solves the phpcs reported issues as well as the issues mentioned in the comment number #6.Please review this patch.

Hi Harsh,
Your patch #11 has been successfully applied, but there are still some remaining errors. Please check the attached screenshot.

I have fixed all the remaining errors in my patch #13. Please review.

This issue has been addressed in related issue:

Closing in favor of 📌 GitlabCI: Fix PHPCS validation errors Needs review .

Thanks everyone for the great work on this issue!