Remove t() calls from classes

Providing new patch with phpcs issue fixes.

I reviewed the patch #9. The patch is failing to apply. Moving it to Needs Works to fix the issue and update the patch.

Thanks!

-    $schema->addIndex('message_digest', 'aggregate', ['timestamp', 'sent', 'notifier'], $spec);
+    $schema->addIndex('message_digest', 'aggregate', [
+      'timestamp', 'sent', 'notifier',
+    ], $spec);

Since this issue focused on removing any call to t() from classes, let's focus on that change. Otherwise, this becomes just another Fix the issues reported by phpcs issue.

Please review.

Test classes should not use translated strings. The last patch does not change the code for the MessageDigestIntervalFormTest class.
Also, since a MR has been used, it would be better to keep using that, instead of creating patches.

+  /**
+   * MessageDigestIntervalListBuilder constructor.
+   *
+   * @param \Drupal\Core\StringTranslation\TranslationInterface $stringTranslation
+   *   The string translation service.
+   */
+  public function __construct(TranslationInterface $stringTranslation) {
+    $this->setStringTranslation($stringTranslation);
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) {
+    $entity_type_manager = $container->get('entity_type.manager');
+    return new static(
+      $entity_type,
+      $entity_type_manager->getStorage($entity_type->id()),
+      $entity_type_manager->getDefinitions()
+    );
+  }

The correct code is similar to the following one.

/**
 * Constructs a new \Drupal\message_digest\MessageDigestIntervalListBuilder object.
 *
 * @param \Drupal\Core\Entity\EntityTypeInterface $entity_type
 *   The entity type definition.
 * @param \Drupal\Core\Entity\EntityStorageInterface $storage
 *   The entity storage class.
 * @param \Drupal\Core\StringTranslation\TranslationInterface $stringTranslation
 *   The string translation service.
 */
public function __construct(EntityTypeInterface $entity_type, EntityStorageInterface $storage, TranslationInterface $string_translation) {
  parent::__construct($entity_type, $storage);
  $this->setStringTranslation($string_translation);
}

/**
 * {@inheritdoc}
 */
public static function createInstance(ContainerInterface $container, EntityTypeInterface $entity_type) {
  return new static($entity_type,
    $container->get('entity_type.manager')->getStorage($entity_type->id()),
    $container->get('string_translation')
  );
}

Test classes should not use translated strings. I think that is what test classes in Drupal core do.

Please review patch.

The last submitted patch, 21: 3145304-21.patch, failed testing. View results →

I updated src/Plugin/Notifier/DigestBase.php. On my local machine, the assert function was not throwing an exception.

I updated it to throw a InvalidDigestGroupingException, but now I am not sure if this is the best exception to throw.

Automatically closed - issue fixed for 2 weeks with no activity.