Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 17 January 2023, almost 2 years ago
Updated 4 June 2024, 7 months ago
📌 Task
Status

Needs work

Version

1.0

Component

Code

Created by

🇮🇳India sahil.goyal

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇮🇳India ayush.khare

    Fixed #3 and Fixed some cs issues.

  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India ayush.khare
  • Assigned to Charchil Khandelwal
  • Comment almost 2 years ago →
    🇮🇳India Charchil Khandelwal

    I will review this.

  • Issue was unassigned.
  • Comment almost 2 years ago →
    🇮🇳India Charchil Khandelwal
  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India Charchil Khandelwal
  • Assigned to indrapatil
  • Comment almost 2 years ago →
    🇮🇳India indrapatil Bangalore

    I am working on it.

  • Comment almost 2 years ago →
    🇮🇳India indrapatil Bangalore

    Hi,
    I worked on the issues and try to solve the issue still have
    some more needs so I am keeping the status "Needs work".

  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

  • Comment over 1 year ago →
    🇮🇳India arpitk

    Hi, I have worked on the remaining issues after patch #10. Fixed all dependency injection issues. Still there are issue when running phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml and need to be fixed. keeping the status as needs work. Please review the patch.

    Thanks!

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    176 pass, 3 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Comment over 1 year ago →
    🇨🇦Canada imustakim Canada

    Issue summary updated.
    Please review.

  • Comment over 1 year ago →
    System Message

    The last submitted patch, 10: Phpcs-coding-3334005-10.patch, failed testing. View results →

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    See arpitk's comment, which explains why the status was not changed.

  • Assigned to RohitRawat676
  • Status changed to Active over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India RohitRawat676

    Fixing Some Coding Standard

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Comment over 1 year ago →
    🇮🇳India RohitRawat676

    Kindly, Review

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    Notice that the patch in #12 📌 Fix the issues reported by phpcs Needs review , which does not fix all the warnings/errors, is bigger than the patch in #17 📌 Fix the issues reported by phpcs Needs review .
    I guess the last patch does not fix all the errors/warnings that should be fixed.

  • Assigned to nitin_lama
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India
  • Comment over 1 year ago →
    🇮🇳India nitin_lama India

    Fixed most of the errors/warning. Providing updated patch.

    Errors/warnings remaining:

    FILE: /home/system/Documents/contribution/paragraphs/paragraphs.api.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
 15 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 17 | ERROR | Missing parameter type
------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/modules/paragraphs_library/src/Form/LibraryItemForm.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 14 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/modules/paragraphs_library/paragraphs_library.install
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 86 | WARNING | Line exceeds 80 characters; contains 86 characters
----------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/modules/paragraphs_demo/paragraphs_demo.module
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------------------
 20 | ERROR   | The array declaration extends to column 421 (the limit is 80). The array content should be split up over multiple lines
 23 | ERROR   | The array declaration extends to column 603 (the limit is 80). The array content should be split up over multiple lines
 28 | WARNING | Code after the RETURN statement on line 26 cannot be executed
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/modules/paragraphs_type_permissions/tests/src/Functional/ParagraphsTypePermissionsTest.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
 185 | ERROR | Unnecessarily gendered language in a comment
-----------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/modules/paragraphs_type_permissions/paragraphs_type_permissions.module
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 29 | WARNING | Code after the RETURN statement on line 27 cannot be executed
---------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Element/ParagraphsActions.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 23 | ERROR | Long array syntax must not be used in doc comment code annotations
--------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Feeds/Target/Paragraphs.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 86 | ERROR | The array declaration extends to column 87 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/ParagraphsBehaviorCollection.php
--------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
 22 | ERROR   | Description for the @return value is missing
 24 | WARNING | Possible useless method overriding detected
 44 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
--------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/MigrationPluginsAlterer.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Entity/ParagraphsType.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 104 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Entity/Paragraph.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 8 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 169 | ERROR   | The array declaration extends to column 183 (the limit is 80). The array content should be split up over multiple lines
 241 | WARNING | Possible useless method overriding detected
 255 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 255 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
 271 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 271 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
 287 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 287 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
 297 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 297 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
 321 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 321 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
 337 | ERROR   | The text '@deprecated Paragraphs no longer have their own author, check the parent entity instead.' does not match the standard format: @deprecated in %deprecation-version% and is removed
     |         | from %removal-version%. %extra-info%.
 337 | ERROR   | Each @deprecated tag must have a @see tag immediately following it
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Annotation/ParagraphsBehavior.php
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
 29 | ERROR | The @var tag must be the first tag in a member variable comment
 38 | ERROR | The @var tag must be the first tag in a member variable comment
------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Form/ParagraphsTypeForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 190 | ERROR | The array declaration extends to column 123 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/EventSubscriber/ReplicateFieldSubscriber.php
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 35 | ERROR | Missing parameter comment
-----------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/migrate/source/d7/FieldCollectionType.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  93 | ERROR   | The text '@deprecated addDescription configuration key is deprecated in 8.x-1.0 and will be removed prior to 9.x.  Use add_description instead.' does not match the standard format:
     |         | @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
 103 | WARNING | The deprecation-version '8.x-1.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n or
     |         | project:n.n.n-label[n]
 103 | WARNING | The removal-version '9.x' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/migrate/source/d7/ParagraphsType.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 81 | ERROR   | The text '@deprecated addDescription configuration key is deprecated in 8.x-1.0 and will be removed prior to 9.x.  Use add_description instead.' does not match the standard format:
    |         | @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
 91 | WARNING | The deprecation-version '8.x-1.0' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n or
    |         | project:n.n.n-label[n]
 91 | WARNING | The removal-version '9.x' does not match the lower-case machine-name standard: drupal:n.n.n or project:n.x-n.n or project:n.x-n.n-label[n] or project:n.n.n or project:n.n.n-label[n]
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/migrate/source/d7/ParagraphType.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  5 | ERROR | The trigger_error message '\Drupal\paragraphs\Plugin\migrate\source\d7\ParagraphType is deprecated in Paragraphs 8.x-1.0 and will be removed before 9.x us *
    |       | \Drupal\paragraphs\Plugin\migrate\source\d7\ParagraphsType instead.  See https://www.drupal.org/project/paragraphs/issues/2911242' does not match the strict standard format: %thing% is
    |       | deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%. See %cr-link%
 11 | ERROR | The text '@deprecated in Paragraphs 8.x-1.0 and will be removed before 9.x use \Drupal\paragraphs\Plugin\migrate\source\d7\ParagraphsType instead.' does not match the standard format:
    |       | @deprecated in %deprecation-version% and is removed from %removal-version%. %extra-info%.
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/EntityReferenceSelection/ParagraphSelection.php
---------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
 143 | ERROR | Missing parameter comment
 143 | ERROR | Missing parameter type
 144 | ERROR | Missing parameter comment
 145 | ERROR | Missing parameter comment
 145 | ERROR | Missing parameter type
---------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 1233 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 1303 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 1372 | ERROR   | Doc comment is empty
 1400 | ERROR   | Doc comment is empty
 1438 | ERROR   | Description for the @return value is missing
 1540 | ERROR   | The array declaration extends to column 179 (the limit is 80). The array content should be split up over multiple lines
 1560 | ERROR   | Missing parameter comment
 1561 | ERROR   | Missing parameter comment
 1596 | ERROR   | Missing parameter comment
 1597 | ERROR   | Missing parameter comment
 1599 | ERROR   | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AND 2 WARNINGS AFFECTING 11 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 1917 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
 2101 | ERROR   | Doc comment is empty
 2124 | ERROR   | Doc comment is empty
 2169 | ERROR   | Missing parameter type
 2567 | ERROR   | The array declaration extends to column 222 (the limit is 80). The array content should be split up over multiple lines
 2616 | ERROR   | Missing parameter comment
 2617 | ERROR   | Missing parameter comment
 2635 | WARNING | Line exceeds 80 characters; contains 86 characters
 2653 | ERROR   | Missing parameter comment
 2654 | ERROR   | Missing parameter comment
 2656 | ERROR   | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Traits/ParagraphsNodeMigrationAssertionsTrait.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
 12 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/FunctionalJavascript/ParagraphsStableEditPerspectivesUiTest.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
 253 | ERROR | String concat is not required here; use a single string instead
------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/ParagraphsWidgetButtonsTest.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 518 | ERROR | Parameter tags must be grouped together in a doc comment
---------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsDuplicateFeatureTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
 14 | ERROR | Missing member variable doc comment
-------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsAdministrationTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 430 | WARNING | Line exceeds 80 characters; contains 128 characters
-----------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsAddModesTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
  75 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
 109 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsDragAndDropModeTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 18 | ERROR | Missing @var tag in member variable comment
------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsReplicateEnableTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 12 | ERROR | Missing member variable doc comment
------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsTestBase.php
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 38 | ERROR | Missing parameter type
-------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsTranslationTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
 637 | WARNING | Line exceeds 80 characters; contains 81 characters
 936 | ERROR   | The array declaration extends to column 161 (the limit is 80). The array content should be split up over multiple lines
 955 | ERROR   | The array declaration extends to column 175 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsEntityTranslationWithNonTranslatableParagraphs.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
 76 | ERROR | Public method name "ParagraphsEntityTranslationWithNonTranslatableParagraphs::testParagraphsIEFTranslation" is not in lowerCamel format
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetStable/ParagraphsInlineEntityFormTest.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
 28 | ERROR | Public method name "ParagraphsInlineEntityFormTest::testParagraphsIEFPreview" is not in lowerCamel format
 84 | ERROR | Public method name "ParagraphsInlineEntityFormTest::testParagraphsIEFChangeOrder" is not in lowerCamel format
----------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsAdministrationTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 426 | WARNING | Line exceeds 80 characters; contains 128 characters
-----------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsAddModesTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
  76 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
 110 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsTestBase.php
-------------------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------
  23 | ERROR | Class property $admin_user should use lowerCamel naming without underscores
  30 | ERROR | Class property $admin_permissions should use lowerCamel naming without underscores
  81 | ERROR | Type hint "array" missing for $additional_permissions
 127 | ERROR | Type hint "array" missing for $paragraphs_types
 157 | ERROR | Missing parameter type
 159 | ERROR | Missing parameter type
 161 | ERROR | Missing parameter type
 163 | ERROR | Missing parameter type
 176 | ERROR | Missing parameter type
-------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsTranslationTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
  41 | ERROR   | Class property $admin_user should use lowerCamel naming without underscores
 334 | ERROR   | The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
 566 | WARNING | Line exceeds 80 characters; contains 81 characters
 854 | ERROR   | The array declaration extends to column 161 (the limit is 80). The array content should be split up over multiple lines
 867 | WARNING | Line exceeds 80 characters; contains 81 characters
 872 | ERROR   | The array declaration extends to column 175 (the limit is 80). The array content should be split up over multiple lines
-----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsEntityTranslationWithNonTranslatableParagraphs.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
 76 | ERROR | Public method name "ParagraphsEntityTranslationWithNonTranslatableParagraphs::testParagraphsIEFTranslation" is not in lowerCamel format
------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Functional/WidgetLegacy/ParagraphsInlineEntityFormTest.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | Public method name "ParagraphsInlineEntityFormTest::testParagraphsIEFPreview" is not in lowerCamel format
 75 | ERROR | Public method name "ParagraphsInlineEntityFormTest::testParagraphsIEFChangeOrder" is not in lowerCamel format
----------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Kernel/ParagraphsBehaviorPluginsTest.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
 76 | ERROR | The array declaration extends to column 127 (the limit is 80). The array content should be split up over multiple lines
 88 | ERROR | The array declaration extends to column 128 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/src/Kernel/ParagraphsCollapsedSummaryTest.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 154 | ERROR | The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/tests/fixtures/update/README.txt
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 11 | WARNING | Line exceeds 80 characters; contains 137 characters
-------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/paragraphs.module
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
  40 | WARNING | Code after the RETURN statement on line 38 cannot be executed
 123 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/system/Documents/contribution/paragraphs/paragraphs.post_update.php
-------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
-------------------------------------------------------------------------------
 19 | ERROR | Missing parameter comment
 19 | ERROR | Missing parameter type
-------------------------------------------------------------------------------

Time: 2.39 secs; Memory: 30MB
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    179 pass, 2 fail
  • Assigned to arti_parmar
  • Comment over 1 year ago →
    🇮🇳India arti_parmar
  • Assigned to Harshita mehra
  • Comment over 1 year ago →
    🇮🇳India Harshita mehra
  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India Harshita mehra
  • Assigned to ankitv18
  • Comment over 1 year ago →
    🇮🇳India ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    159 pass, 12 fail
  • Merge request !70Issue-3334005: Phpcs fixes. → (Open) created by ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    165 pass, 10 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    172 pass, 4 fail
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    159 pass, 12 fail
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India ankitv18

    Can someone review MR!70?
    If issue queue doesn't have D10.1 compatibility ticket, can we create one and cover D10.1 test failure in that?

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    180 pass
  • Issue was unassigned.
  • Comment over 1 year ago →
    🇮🇳India ankitv18
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    180 pass
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.7 + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    180 pass
  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇫🇷France tart0 Nantes, France
  • Comment 9 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    apaderno → changed the visibility of the branch 3334005-drupal-coding-standards to hidden.

  • Merge request !104Issue #3334005: Fix the issues reported by phpcs → (Open) created by apaderno
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22
    last update 9 months ago
    182 pass
  • Pipeline finished with Failed
    9 months ago
    Total: 268s
    #133195
  • Comment 9 months ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹
  • First commit to issue fork.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024