The patch primarily updates the .yml file and appears solid upon review.
I successfully applied the patch and ran the module without encountering any alerts or issues.
However, I couldn't test more advanced features, so this review is partial. Further testing would be beneficial to confirm the module's full functionality.
The patch primarily updates the .yml file and appears solid upon review.
I successfully applied the patch and ran the module without encountering any alerts or issues.
However, I couldn't test more advanced features, so this review is partial. Further testing would be beneficial to confirm the module's full functionality.
The patch primarily updates the .yml file and appears solid upon review.
I successfully applied the patch and ran the module without encountering any alerts or issues.
However, I couldn't test more advanced features, so this review is partial. Further testing would be beneficial to confirm the module's full functionality.
The patch primarily updates the .yml file and appears solid upon review.
I successfully applied the patch and ran the module without encountering any alerts or issues.
However, I couldn't test more advanced features, so this review is partial. Further testing would be beneficial to confirm the module's full functionality.
The patch primarily updates the .yml file and appears solid upon review.
I successfully applied the patch and ran the module without encountering any alerts or issues.
However, I couldn't test more advanced features, so this review is partial. Further testing would be beneficial to confirm the module's full functionality.
@nicrodgers Given that Drupal 10.1 has reached end-of-life and is no longer maintained, dropping support for it seems reasonable. Removing compatibility with deprecated versions can streamline the codebase and reduce technical debt, allowing for a more efficient implementation of current best practices, including using utilities like DeprecationHelper
. Moreover, aligning with supported versions ensures we stay updated with security patches and new features.
Ah snap ! Global settings weren't applied ... I guess same on https://www.drupal.org/project/collapsiblock β , i'll fix it right now, sorry
Tart0 β changed the visibility of the branch 3433133-cspell---enable to hidden.
Tart0 β changed the visibility of the branch 3436803-render-s-callbacks to active.
Tart0 β changed the visibility of the branch 3436803-render-s-callbacks to hidden.
Sorry to reviewers for the mess, got some trouble with PHPStan ^^'
Tart0 β made their first commit to this issueβs fork.
Thanks for the FYI @AstonVictor !
Works for me ! Thanks
Works well, thanks for the patch
Looks great, thanks for the patch !
Patch tested, this fix the issue, thanks !
Patch works fine, thanks for it !
@longwave wasn't aware of that meta issue, i'll give a look and provide as much as I can, thanks !
I think, a lot of "old" jQuery code could / should be moved to vanilla to prevent most of those deprecations.