- Issue created by @joachim
- First commit to issue fork.
- Merge request !7260Update message "Render %s callbacks must be methods of a class that implements" with attribute β (Open) created by Unnamed author
- Status changed to Needs review
9 months ago 1:50am 1 April 2024 - π«π·France tart0 Nantes, France
Sorry to reviewers for the mess, got some trouble with PHPStan ^^'
- Assigned to tart0
- Status changed to Needs work
9 months ago 6:49am 1 April 2024 - π¬π§United Kingdom joachim
The MR is making far too many changes -- it seems to be updating all the callbacks to use the attribute. Which is a good change, and there may be an other issue where you should contribute those changes so they're not wasted.
But this issue is about changing just one message string.
- π«π·France Grimreaper France π«π·
Hi,
Also currently in the message: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
$message = sprintf('Render %s callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', $callback_type, '%s');
"The callback was %s" is not replaced. Should it pass $callback as third argument?
- π¬π§United Kingdom joachim
Issues should only fix one thing, so that would be for a separate issue, done as a follow-up to this one (as otherwise they would clash).
- π¬π§United Kingdom jacobupal Leeds
Removed novice tag as it wouldn't be for a novice to split this into separate issues and/or meta issues.
- π¬π§United Kingdom joachim
joachim β changed the visibility of the branch 3436803-render-s-callbacks to hidden.
- π¬π§United Kingdom joachim
joachim β changed the visibility of the branch 3436803-render-s-callbacks to active.
- π¬π§United Kingdom joachim
joachim β changed the visibility of the branch 3436803-render-s-callbacks to hidden.
- π¬π§United Kingdom joachim
I started a new branch, as it was going to be too much work to unpick the existing branch.
- Merge request !9605Added mention of TrustedCallback attribute to error message. β (Open) created by joachim